Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that milestone message PoW is 0 #1374

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Check that milestone message PoW is 0 #1374

merged 3 commits into from
Apr 28, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Apr 28, 2022 •
edited
Loading

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added c-feature Category - Feature e-medium Experience - Medium p-high Priority - High wg-protocol Working Group - Protocol n-shimmer Network - Shimmer labels Apr 28, 2022
grtlr
grtlr previously approved these changes Apr 28, 2022
View reviewed changes
bee-protocol/src/workers/message/processor.rs Outdated Show resolved Hide resolved
thibault-martinez and others added 2 commits April 28, 2022 10:29
@thibault-martinez @grtlr
Update bee-protocol/src/workers/message/processor.rs
e6f6d38 
Co-authored-by: Jochen Görtler <grtlr@users.noreply.github.com>
@thibault-martinez
Clippy
ff2532b
@thibault-martinez thibault-martinez merged commit f940e29 into iotaledger:shimmer-develop Apr 28, 2022
@thibault-martinez thibault-martinez deleted the milestone-pow-0 branch April 28, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@grtlr grtlr grtlr left review comments

Assignees
No one assigned
Labels
c-feature Category - Feature e-medium Experience - Medium n-shimmer Network - Shimmer p-high Priority - High wg-protocol Working Group - Protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thibault-martinez @grtlr @samuel-rufi @Thoralf-M