Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Message::LENGTH_MIN #1393

Merged
merged 1 commit into from
May 5, 2022
Merged

Fix Message::LENGTH_MIN #1393

merged 1 commit into from
May 5, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented May 5, 2022 •
edited
Loading

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-message Working Group - Message c-bug Category - Bug e-low Experience - Low p-critical Priority - Critical n-shimmer Network - Shimmer labels May 5, 2022
@thibault-martinez thibault-martinez added this to the v1.0 milestone May 5, 2022
@thibault-martinez thibault-martinez merged commit ebaac80 into iotaledger:shimmer-develop May 5, 2022
@thibault-martinez thibault-martinez deleted the fix-message-length-min branch May 5, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@pvdrz pvdrz pvdrz approved these changes

@bingyanglin bingyanglin Awaiting requested review from bingyanglin

Assignees
No one assigned
Labels
c-bug Category - Bug e-low Experience - Low n-shimmer Network - Shimmer p-critical Priority - Critical wg-message Working Group - Message
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thibault-martinez @pvdrz @Thoralf-M