Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protocol version to milestone essence #1399

Merged
merged 3 commits into from
May 19, 2022
Merged

Add protocol version to milestone essence #1399

merged 3 commits into from
May 19, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented May 9, 2022 •
edited
Loading

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-message Working Group - Message c-feature Category - Feature e-low Experience - Low p-medium Priority - Medium n-shimmer Network - Shimmer labels May 9, 2022
@thibault-martinez
Copy link
Member Author

Don't merge yet.

@samuel-rufi samuel-rufi self-requested a review May 9, 2022 11:02
@thibault-martinez thibault-martinez merged commit 8e0b6fb into iotaledger:shimmer-develop May 19, 2022
@thibault-martinez thibault-martinez deleted the milestone-essence-protocol-version branch May 19, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingyanglin bingyanglin bingyanglin approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

Assignees
No one assigned
Labels
c-feature Category - Feature e-low Experience - Low n-shimmer Network - Shimmer p-medium Priority - Medium wg-message Working Group - Message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thibault-martinez @samuel-rufi @bingyanglin