ci: Fix Windows build #6826
Merged
ci: Fix Windows build #6826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
added
os:windows
rajivshah3
requested review from
begonaalvarezd,
maxwellmattryan,
Tuditi and
nicole-obrien
nicole-obrien
approved these changes
May 17, 2023
begonaalvarezd
added a commit
that referenced
this pull request
Jul 27, 2023
* chore: update CI for release branch (#6816) * chore: update CI * chore: update Snyk CI * chore: 6th ASMB staking period (#6798) * chore: update constants * chore: add event and times * chore: update version --------- Co-authored-by: Tuditi <daviddetroch@pm.me> * chore: update ubuntu version in build action * chore: update tokio version * chore: update neon version * chore: force python version * ci: Fix Windows build (#6826) * ci: specify rust toolchain v1.67.0 * ci: set override rust toolchain * ci: Use windows-latest and Visual Studio 2022 * ci: Only install Python 2.x on macOS * ci: Install node-gyp 9.3.1 * fix: Patch neon-sys and node-gyp * ci: Apply patches during workflow * ci: Bug fixes * Debug * Try fixing bugs * Patch Cargo.toml on Windows --------- Co-authored-by: Begoña Alvarez <balvarez@boxfish.studio> --------- Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Tuditi <daviddetroch@pm.me> Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
windows-latestand Visual Studio 2022node-gyp9.3.1Changelog
N/A
Testing
Platforms
Instructions
App should launch and run properly
Builds are available here
Checklist