Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: started implementing TransactionConfirmed event #2168

Merged
merged 21 commits into from
Apr 25, 2022

Conversation

hmoog
Copy link
Contributor

@hmoog hmoog commented Apr 21, 2022

Description of change

Please write a summary of your changes and why you made them. Be sure to reference any related issues by adding fixes # (issue).

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@hmoog hmoog merged commit 11c20b1 into feat/multithreaded-tangle Apr 25, 2022
jonastheis added a commit that referenced this pull request May 31, 2022
…ctions (#2151)

* Refactor: started to comment utils

* Feat: started refactoring models

* Feat: commented ChildBranch

* Fix: fixed bug with default options

* Refactor: refactored Conflict

* Refactor: removed unused code

* Feat: finished branchdag refactor

* Refactor: refactored some code

* Add multithreaded test for solidification and propagation (#2147)

* Feat: commented Ledger (models missing)

* Add tests for edge cases

* remove unused code

* Refactor: refactored code

* Add tests for childbranches when asserting branch DAG references

* Refactor: refactored code

* Fix: fixed some refactor bugs

* Fix: fixed refactor errors in devnetvm

* Feat: go mod tidy

* Feat: commented Outputs

* Feat: commented more code

* Feat: commented models

* Refactor: reviewed the code

* Refactor: changed more code

* Add comments to testframework

* Add locks to testframework

* Feat: added comments for properties in TestFramework

* Start implementing new tangle data flow

* Fix: fixed some random things

* Feat: started implementing error handling

* Fix: fixed some random stuff

* Feat: added comment

* Feat: added Shutdown calls

* Feat: added context to all final events Booked/Invalid

* change to improved data flow and embed payloadbooker into booker

* Rename ledgerstate to ledgerstateOLD in preparation to get rid of it. Add new ledger to Tangle

* WIP

* WIP

* fix more errors

* Feat: added UndefinedBranchID

* fix more errors

* Feat: refactored comment

* Feat: use EventLoop for gossip manager

* Feat: fixed some bugs

* Fix: fixed some random code

* fix more stuff

* Feat: more generic events

* Feat: started implementing indexer

* Feat: more generic events

* Feat: more generic events

* Feat: more generic events

* Feat: more generic events

* Feat: added an Indexer for the devnetvm

* Fix: fixed more random things

* Fix: fixed approvalweightmanager

* fix more and more stuff

* Feat: more generic events

* Fix: fixed more stuff

* Fix: fixed more bugs

* Feat: more generic events

* Feat: upgrade hive.go

* Fix: change workerpool in tangle_test

* Fix: fixed workerpool

* Feat: more generic events

* Feat: fixed wallet + client

* Fix: fixed some stuff in otv test

* Fix: fixed more stuff in otv.test

* Feat: more generic events

* Fix: remove replace in go.mod

* Fix: fixed otv_test

* Fix: fixed more stuff

* Fix: fixed more stuff

* Fix: fixed more ledgerstate references

* Fix: removed all references to ledgerstate package

* Feat: started adding snapshots

* Fix more errors

* Fix more stuff

* Fix more compile errors, only snapshot left now

* Feat: Implemented TransactionConfirmed event (#2168)

* Feat: Implemented TransactionConfirmed event

* Feat: started implementing mana snapshit

* Feat: node builds

* Refactor: simplified code by removing some wrappers

* Fix: fixed refactor related bugs

* Refactor: removed Transaction wrapping

* Fix: fixed broken mocks

* Update to latest hive.go version and fix out of order event error on startup

* Fix permissions in Docker file when mounting volume

* Feat: started reworking snapshot logic

* Feat: added OutputMetadata snapshot

* Feat: added more snapshot stuff

* Feat: fixed create snapshot tool

* Fix snapshit generation

* Fix uninitialized events

* Fix: fixed problem in booker

* Use eventloop instead of goroutines

* Add snapshot to Docker network and index outputs from snapshot when loading it

* Fix: fixed waiting in tests

* Feat: debug

* Fix: fixed some stuff

* Fix: removed unused code

* debug tests and stuff

* Feat: added debug outputs

* Fix one issue with out of order test

* Hook forking events

* Fix: fixed stuff

* Fix: fixed some stuff

* Feat: refactored solidifier

* Fix: fix bug

* Fix: booker_test TestScenario_1

* Fix: fixed test

* Fix: fixed test

* Fix: fixed tests

* Fix: fixed otv test

* Fix: fixed broken plugins

* Fix: fixed go.mod

* Fix: fixed some minor things

* Fix: fixed go.mod

* Fix: fixed broken test

* Feat: TSA remove past-cone checks and unconfirmed weak references

* Feat: upgraded to latest hive.go

* Feat: implemented commitment and proof systems for state commitments

* Fix: fixed order in booking

* tangle booker test

* Fix TestMultiThreadedBookingAndForking

* Fix: debug.Enabled race condition

* Fix: make tests more solid

* Feat: generic branchdag (#2204)

* Bump hive version

* Remove debugging prints

* Bump hive.go to fix serializer/v2 nested module

* Fix: TestMultiThreadedBookingAndForking test

* Refactor: renamed BranchDAG to ConflictDAG

* Refactor: started cleaning up stuff

* Fix: code warnings

* Feat: removed MasterBranch

* Feat: TestMultiThreadedBookingAndForkingNested

* Fix: BranchDAG -> ConflictDAG renaming

* Faster TestMultiThreadedBookingAndForkingNested

* Fix snapshot generation with new snapshotcreator tool

* Fix: fixed snapshit

* Feat: feed outputs to the messagelayer Indexer

* Fix: make sure ConflictIDs are empty sets

* Fix snapshot generation for integration tests

* Fix common integration tests

* Fix autopeering integration test

* Remove diagnostics integration tests

* Remove drng integration tests

* Fix: dashboard

* Fix: fixed some tests

* Fix: dashboard again

* Fix: fixed some stuff

* Fix: fixed test

* Fix: fixed stuff

* Fix: some unit tests

* Fix mana integration tests

* Fix faucet integration tests

* Feat: renamed branchdag

* Refactor: moved conflictdag package

* Refactor: refactored more conflictdag models

* Fix faucet integration tests

* Fix value integration tests

* Fix nil pointer in conflicts dashboard

* Fix reference creation for shallow dislike and TestConflictSpamAndMergeToMaster integration test

* Fix consensus integration tests

* Run integration tests for multithreaded tangle (#2217)

* Adjust runTests.sh

* Add missing context import

* Fix: dashboard

* Refactor: refactored code

* Fix: critical - return strongparent as-is if branch liked

* Refactor: cleaned up stuff

* Merge develop

* Revert "Fix: critical - return strongparent as-is if branch liked"

This reverts commit 74288b2.

* Fix issue where liked branch is not returned when LikedConflictMember is called with the liked branch of the conflict set (#2174)

* Add Feature network identities in snapshot creation tool

* WIP

* Make code compile

* Fix output unmarshallimg

* Fix: do not evaluate time difference if message approves Genesis

* Fix: Faucet properly attach async events

* Feat: cleaned up first model

* Adjust models in conflict dag

* Fix: fixed conflictdag

* Fix: fixed some more stuff

* fixed test

* Ledger tests pass

* Ledger tests and devnetvm tests pass again

* Fix indexer

* Fix objectstorage interface for some objects

* Use serix for model.Model serialization

* Fix more stuff

* Fix: fixed stuff

* Refactor: removed unnecessary helper

* Feat: cleaned up more code

* Refactor: changed to new models

* Fix more stuff

* Fix snapshit again

* Fix: fixed bug with models

* Bump hive.go

* Few fixes and prints

* Feat: added test for outputcommitment

* Add manual serialization to Ouput types to enable correct interface (de)serialization

* go mod tidy

* Fix value test hopefully

* Fix unsanitized user input print

* Fix: removed unused identifier

* Update CHANGELOG.md

* Update pkger

Co-authored-by: Hans Moog <3293976+hmoog@users.noreply.github.com>
Co-authored-by: Andrea V <1577639+karimodm@users.noreply.github.com>
@jkrvivian jkrvivian deleted the feat/ledger-TransactionConfirmed branch October 25, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants