Snapshot mana epochs #2265
Merged
Snapshot mana epochs #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimodm
suggested changes
Jun 9, 2022
packages/snapshot/snapshot.go
Outdated
| ) | ||
|
|
||
| type Snapshot struct { | ||
| LedgerSnapshot *ledger.Snapshot | ||
| ManaSnapshot *mana.Snapshot |
There was a problem hiding this comment.
Can we just have the inner struct as this now has only one field?
There was a problem hiding this comment.
I would leave it as is for now. Maybe we will add another field in the future, then we would need to change it back.
packages/mana/consensusbasevector.go
Outdated
| BaseMana1: value, | ||
| } | ||
| } | ||
| func (c *ConsensusBaseManaVector) LoadSnapshot(snapshot map[identity.ID]float64) { |
There was a problem hiding this comment.
Here we just store the base vector right?
Also let's maybe change the function name.
There was a problem hiding this comment.
Yes, we populate the vector with the map data.
Sure, I changed the name.
packages/mana/accessbasevector.go
Outdated
| ManaType: a.Type(), | ||
| }) | ||
| } | ||
| func (a *AccessBaseManaVector) LoadSnapshot(snapshot map[identity.ID]float64) { |
There was a problem hiding this comment.
Here we just store the base vector right?
Also let's maybe change the function name.
There was a problem hiding this comment.
Yes, we populate the vector with the map data.
Sure, I changed the name.
daria305
reviewed
Jun 9, 2022
# Conflicts: # packages/mana/basevector.go # packages/mana/events_test.go # packages/mana/manabasevector.go # tools/docker-network/docker-network.snapshot
This reverts commit 862dfae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.