Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoch commitment metrics #2293

Merged
merged 304 commits into from
Jul 8, 2022
Merged

Epoch commitment metrics #2293

merged 304 commits into from
Jul 8, 2022

Conversation

georgysavva
Copy link
Contributor

Fixes: #2270

georgysavva and others added 30 commits June 2, 2022 10:52
…load

# Conflicts:
#	packages/notarization/commitments.go
…/epoch-commitment

# Conflicts:
#	packages/notarization/commitments.go
#	packages/notarization/manager.go
* Add ECCommitable event

* Rename event and trigger it when EC is first requested

Co-authored-by: Daria Dziubałtowska <daria.dziubaltowska@iota.org>
…er into feat/epoch-commitment

 Conflicts:
	packages/epoch/types.go
	packages/notarization/commitments.go
	packages/notarization/manager.go
	packages/notarization/storage.go
Base automatically changed from feat/epoch-commitment to develop July 5, 2022 08:19
@jkrvivian jkrvivian force-pushed the feat/ec-chain-display branch from ced7a98 to 4829a23 Compare July 5, 2022 09:15
Copy link
Contributor

@karimodm karimodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very impressed by the codebase, good quality! I just have a bunch of style comments and a couple more tricky ones!

packages/jsonmodels/info.go Outdated Show resolved Hide resolved
packages/notarization/manager.go Outdated Show resolved Hide resolved
packages/notarization/manager.go Outdated Show resolved Hide resolved
packages/notarization/manager.go Outdated Show resolved Hide resolved
packages/notarization/manager.go Outdated Show resolved Hide resolved
plugins/epochstorage/plugin.go Outdated Show resolved Hide resolved
plugins/epochstorage/plugin.go Outdated Show resolved Hide resolved
plugins/metrics/epochcommittment.go Show resolved Hide resolved
plugins/metrics/plugin.go Show resolved Hide resolved
plugins/epochstorage/plugin.go Show resolved Hide resolved
Copy link
Contributor

@karimodm karimodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@karimodm karimodm merged commit 6e4203a into develop Jul 8, 2022
@karimodm karimodm deleted the feat/ec-chain-display branch July 8, 2022 09:24
karimodm added a commit that referenced this pull request Jul 8, 2022
@karimodm karimodm restored the feat/ec-chain-display branch July 8, 2022 09:27
This was referenced Jul 14, 2022
@karimodm karimodm deleted the feat/ec-chain-display branch August 31, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EC chains display in Dashboard or Grafana
4 participants