-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement simplified faucet #2391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use client/wallet
package to manage funds and addresses instead of having to manage it in the faucet plugin. It'd make the code more simple and readable.
If we configure the wallet to reuse the same address, then it will always read the correct state from the tangle.
It also would be nice to only handle requests that are not older than X minutes, because otherwise in case of faucet node restart, it would try to fullfill all the requests again.
1479d84
to
ec846df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the faucet request window check, fix the tests and I think it's good to go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks already pretty good and makes everything so much simpler. But I think some things can still be improved
…a faucet request in the second transaction and simplify code even more
Description of change
Type of change
Change checklist