-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reexported Resolver
validation APIs
#1183
Merged
PhilippGackstatter
merged 25 commits into
main
from
chore/remove-resolver-validation-apis
Jun 13, 2023
Merged
Remove reexported Resolver
validation APIs
#1183
PhilippGackstatter
merged 25 commits into
main
from
chore/remove-resolver-validation-apis
Jun 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGackstatter
added
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
Breaking change
A change to the API that requires a major release. Part of "Changed" section in changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
labels
Jun 12, 2023
abdulmth
approved these changes
Jun 12, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking change
A change to the API that requires a major release. Part of "Changed" section in changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Remove the reexported
Resolver
APIs that re-expose functionality fromCredentialValidator
andPresentationValidator
. The latter APIs should be used instead.Resolving and validating is slightly more hands-on now as a result, but reduces the Resolver's API surface and therefore complexity significantly. It also gives a better decoupling of resolution and validation, especially for handling errors that occur in either of those processes. The resolver
Error
also no longer has to re-export the validation errors, making it simpler too.Overall this should result in less complexity for the user as well as the maintainers with not much impact on the API as is evident by the updated examples.
This also updates some examples to use the new JWT-based APIs, since this PR is part of a larger effort to remove the old Validators in favor of the new JWT-based ones.
Links to any relevant issues
part of #1103
Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Updated examples and ran them successfully.
Change checklist
Add an
x
to the boxes that are relevant to your changes.