WASM32 - Redesigned crate architecture #1497
Open
+25,563
−1,421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MoveType has been moved from identity_iota_core to identity_iota_interaction * The identity_iota_interaction README has been updated to use the latest draft for folder and crate names
…iota_interaction::...`
…lpha # Conflicts: # identity_iota_core/Cargo.toml # identity_iota_core/src/rebased/iota/well_known_networks.rs
…ta_core/rebase version
…ta_core for the redesigned crate structure
* Compiling identity_iota_core for wasm32 will result in one compiler error
due to missing wasm-bindings for ProgrammableTransaction
(TODO in identity_iota_core/src/rebased/transaction.rs)
* identity_iota_core and examples are compilable for non wasm32 platforms
* Remaining compiler warnings should be investigated
* identity_iota_core e2e tests are compilable but will fail due to serialization/deserialization issues.
For example:
IotaTransactionBlockResponse bcs deserialization failed: NotSupported("deserialize_any")
thread 'identity::adding_controller_works' panicked at /home/christof/Develop/iotaledger/identity.rs/identity_iota_core/src/rebased/transaction.rs:84:14:
IotaTransactionBlockResponse bcs deserialization failed: NotSupported("deserialize_any")
stack backtrace:
0: rust_begin_unwind
1: core::panicking::panic_fmt
2: core::result::unwrap_failed
3: <identity_iota_core::rebased::transaction::TransactionOutput<T> as core::convert::From<identity_iota_core::rebased::transaction::TransactionOutputInternal<T>>>::from
4: <T as identity_iota_core::rebased::transaction::Transaction>::execute_with_opt_gas::{{closure}}
5: identity_iota_core::rebased::transaction::Transaction::execute::{{closure}}
6: e2e::identity::adding_controller_works::{{closure}}
7: tokio::runtime::scheduler::current_thread::CurrentThread::block_on
8: tokio::runtime::runtime::Runtime::block_on
9: e2e::identity::adding_controller_works
10: core::ops::function::FnOnce::call_once
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
…ialization BCS deserialization is not available for IotaTransactionBlockResponse because the BCS format is not self describing and several struct fields of IotaTransactionBlockResponse are optionally skipped during serialization. JSON deserialization will probably be available but using a cloned instance to convert a TransactionOutputInternal into a TransactionOutput will have a much better efficiency.
…Credential All tests running successfully for the first time now
chrisgitiota
added
Wasm
* Fix clippy error writing `&Vec` instead of `&[_]` involves a new object where a slice will do * allow error clippy::too_many_arguments
UMR1352
approved these changes
Jan 8, 2025
|
I'm currently investigating the formating issues. Using the nightly version of rustfmt we could use the unstable option ignore for this. As we are using the +nightly CLI option (according to the console log) this should work. Otherwise I will give rustfmt::skip a try. |
… from format checks
…nd identity_iota_interaction
…iles and add clippy + format steps for bindings/wasm/iota_interaction_ts
UMR1352
approved these changes
Jan 9, 2025
…s crate is processed as workspace member
…MEs and gitignore files
… words and specific contributor copyrights
…gs/wasm/identity_wasm" because bindings/wasm/iota_interaction_ts is needed to build the docker image
wulfraem
requested changes
Jan 10, 2025
Comment on lines
+1
to
+2
| {(\/\/ Copyright.*\n)*?}// {(Modifications )?}Copyright {(\(c\) )?}{20\d{2}(-20\d{2})?} IOTA Stiftung{(, Fondazione Links)?}{(, Filancore GmbH)?} | ||
| {(\/\/ Copyright.*\n)*}// SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Would this update to the template make sense? ^^
Suggested change
| {(\/\/ Copyright.*\n)*?}// {(Modifications )?}Copyright {(\(c\) )?}{20\d{2}(-20\d{2})?} IOTA Stiftung{(, Fondazione Links)?}{(, Filancore GmbH)?} | |
| {(\/\/ Copyright.*\n)*}// SPDX-License-Identifier: Apache-2.0 | |
| {(\/\/ Copyright.*\n)*?}// {(Modifications )?}Copyright {(\(c\) )?}{20\d{2}(-20\d{2})?} IOTA Stiftung{(?:, .+)?} | |
| // SPDX-License-Identifier: Apache-2.0 |
This would:
- keep the list of non-IOTA contributors open, so that we don't have to extend it for contributions from currently unlisted contributors
- remove the
// Copyrightprefix from the second line, as I didn't find any cases where we needed it ^^;;
There was a problem hiding this comment.
Would running cargo +nightly fmt make sense before merging?
Had these changes after running it:
git diff --shortstat
49 files changed, 423 insertions(+), 506 deletions(-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR introduces the new crate structure as been described in issue #1441.
Links to any relevant issues
Closes #1441
Type of change
How the change has been tested
cargo build --package identity_iota_core --lib --target wasm32-unknown-unknown --no-default-features --features iota-client --features revocation-bitmapRegarding changes in MoveCalls originating from other currently opened PRs
The folder
identity_iota_core/src/rebased/iota/move_callsis not used anymore but has not been deleted so far. Changes to this folder, resulting from other currently opened PRs will automatically be merged without problems. After these changes have been merged intoidentity_iota_core/src/rebased/iota/move_callsthey need to be integrated manually into the filesidentity_iota_core/src/iota_interaction_rust/asset_move_calls.rsandidentity_iota_core/src/iota_interaction_rust/identity_move_calls.rs.After this PR and all other PRs impacting
identity_iota_core/src/rebased/iota/move_callshave been merged as described above, the folderidentity_iota_core/src/rebased/iota/move_callsmust be deleted.