-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename types to contain prefixes (Core, Iota, Wasm) #219
Conversation
dd7a78b
to
e8efcba
Compare
Did you run clippy for wasm locally? It runs separately from the main
|
Ahhhh of course!!! All fixed now (hopefully) 🙃 |
@m-renaud thanks for doing this - I'm looking forward to these changes; should be able to merge as soon as those conflicts are resolved 😛 |
4014e4b
to
ceccc9c
Compare
ceccc9c
to
281635d
Compare
* Rename types to contain prefixes (Core, Iota, Wasm) * Resolve compilation errors in wasm code * Rename WasmDID to DID in JS. * Rename IotaMethod->IotaVerificationMethod and WasmMethod->WasmVerificationMethod * Address @l1h3r comments * Fix compilation errors.
Description of change
Rename types with common names to contain prefixes.
identity-did/src/document/document.rs
->identity-did/src/document/core_document.rs
Document
->CoreDocument
identity-did/src/verification/method.rs
->identity-did/src/verification/verification_method.rs
Method
->VerificationMethod
identity-iota/src/did/doc/document.rs
->identity-iota/src/did/doc/iota_document.rs
Document
->IotaDocument
identity-iota/src/did/doc/method.rs
->identity-iota/src/did/doc/iota_method.rs
Method
->IotaMethod
identity-iota/src/did/url/did.rs
->identity-iota/src/did/url/iota_did.rs
DID
->IotaDID
bindings/wasm/src/document.rs
->bindings/wasm/src/wasm_document.rs
Document
->WasmDocument
bindings/wasm/src/method.rs
->bindings/wasm/src/wasm_method.rs
Method
->WasmMethod
bindings/wasm/src/did.rs
->bindings/wasm/src/wasm_did.rs
DID
->WasmDID
Discussion in #218
Links to any relevant issues
#218
Type of change
How the change has been tested
This PR contains type renames and file moves only. Thankfully Rust has a great type system so if it compiles, it should work :)
cargo build
andcargo test
both succeed.cargo clippy
for targetaarch64-apple-darwin
passes locally, but for some reason is failing in GitHub actions.Change checklist