Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Make integration tests executable #233

Merged

Conversation

ezienecker
Copy link
Contributor

Description of change

Integration tests were not executable via maven. I have added a profile that allows this.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Run mvn clean test -PallTests

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests using ginkgo that prove my fix is effective or that my feature works -> not needed
  • New and existing unit tests pass locally with my changes -> not needed

@kwek20
Copy link
Contributor

kwek20 commented Oct 5, 2020

Wow the tests are seriously broken... Ill take a look after your 2 prs 👍

@kwek20 kwek20 merged commit 5aec4a6 into iotaledger:dev Oct 5, 2020
@ezienecker
Copy link
Contributor Author

Wow the tests are seriously broken... Ill take a look after your 2 prs 👍

@kwek20 I'm currently working on this: #174 after this most of the integration are no longer needed. Until then we should leave it as it is.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants