Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up wallet syncing code #2108

Merged
merged 46 commits into from
Apr 30, 2024
Merged

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Mar 1, 2024

Description of change

An attempt at cleaning up some wallet syncing code.

Links to any relevant issues

#1905

@Alex6323 Alex6323 linked an issue Mar 1, 2024 that may be closed by this pull request
@Alex6323 Alex6323 marked this pull request as ready for review March 14, 2024 22:03
Copy link

@DaughterOfMars DaughterOfMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I don't like the name. Maybe ExtendedOutputMetadata would be better? I would even be happier just leaving it OutputData...

@Alex6323
Copy link
Contributor Author

Alex6323 commented Mar 27, 2024

tbh I don't like the name. Maybe ExtendedOutputMetadata would be better? I would even be happier just leaving it OutputData...

yeah, believe me when I say I am not fond of this name either, but I remember us all not really liking ...Data types (looking at you WalletData), because that's just a lazy name giving you no clue at all about what it contains, i.e. everything is data.

Anyways in this case we can make an exception, I guess 🤷‍♂️

@thibault-martinez
Copy link
Member

tbh I don't like the name. Maybe ExtendedOutputMetadata would be better? I would even be happier just leaving it OutputData...

yeah, believe me when I say I am not fond of this name either, but I remember us all not really liking ...Data types (looking at you WalletData), because that's just a lazy name giving you no clue at all about what it contains, i.e. everything is data.

Anyways in this case we can make an exception, I guess 🤷‍♂️

But we said we'll revert the rename anyway?

@Alex6323 Alex6323 merged commit 3e44c80 into iotaledger:2.0 Apr 30, 2024
37 checks passed
@Alex6323 Alex6323 deleted the cleanup-wallet-syncing branch April 30, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup wallet syncing code
4 participants