Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SecretManage to be extensible #462

Merged
merged 41 commits into from
Jun 14, 2023

Conversation

DaughterOfMars
Copy link

Description of change

Updates the SecretManage trait so that it can be extended by users and provided to a Wallet and Account, thereby enabling its usage via rust. This does not add the ability to pass a custom Secret Manager to the client methods that accept one, however, it may enable us to refactor those methods later to allow passing one in.

Links to any relevant issues

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Open Questions

  • I tried to make the types default to use the SecretManager enum, but this only seems to affect the impl blocks. So, I created a new type definition for the default and exported it from the top level. Not sure this is the best way.

Thoralf-M
Thoralf-M previously approved these changes May 24, 2023
Thoralf-M
Thoralf-M previously approved these changes May 26, 2023
Thoralf-M
Thoralf-M previously approved these changes Jun 9, 2023
@thibault-martinez thibault-martinez merged commit 80b458f into develop Jun 14, 2023
@thibault-martinez thibault-martinez deleted the feat/extensible-secret-manager branch June 14, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Trait in favor of enum for SecretManager
6 participants