-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow SecretManage to be extensible #462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thibault Martinez <thibault@iota.org>
Thoralf-M
reviewed
May 24, 2023
Thoralf-M
reviewed
May 24, 2023
Thoralf-M
reviewed
May 24, 2023
Thoralf-M
previously approved these changes
May 24, 2023
Thoralf-M
reviewed
May 26, 2023
Thoralf-M
reviewed
May 26, 2023
Thoralf-M
previously approved these changes
May 26, 2023
Thoralf-M
reviewed
Jun 8, 2023
Thoralf-M
reviewed
Jun 8, 2023
Thoralf-M
previously approved these changes
Jun 9, 2023
kwek20
approved these changes
Jun 13, 2023
Alex6323
reviewed
Jun 14, 2023
Alex6323
reviewed
Jun 14, 2023
Alex6323
reviewed
Jun 14, 2023
Alex6323
reviewed
Jun 14, 2023
Alex6323
reviewed
Jun 14, 2023
Alex6323
reviewed
Jun 14, 2023
Alex6323
reviewed
Jun 14, 2023
Alex6323
reviewed
Jun 14, 2023
Alex6323
reviewed
Jun 14, 2023
Alex6323
reviewed
Jun 14, 2023
thibault-martinez
approved these changes
Jun 14, 2023
Alex6323
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates the
SecretManage
trait so that it can be extended by users and provided to aWallet
andAccount
, thereby enabling its usage via rust. This does not add the ability to pass a custom Secret Manager to the client methods that accept one, however, it may enable us to refactor those methods later to allow passing one in.Links to any relevant issues
Type of change
Choose a type of change, and delete any options that are not relevant.
Open Questions
SecretManager
enum, but this only seems to affect the impl blocks. So, I created a new type definition for the default and exported it from the top level. Not sure this is the best way.