This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Removing transaction symbols from package namespace #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to replay the bundle.
Fixes replayed bundle being reversed
Release/2.0.0
fix transfer = ProposedTransaction(...) naming convention doesn't follow other libs iotaledger#72
Issue iotaledger#45: Seed check
The previous name will still work, but it is deprecated and will be removed in PyOTA v2.1.
…esFromTrytes Renamed 'trytes' codec to 'trytes_ascii'.
usage of bundle hash by find_transactions
…t-account-data iotaledger#181 security_level into get_account_data
Change `depth` to 3 in examples
Some notable changes: * Add argparse interface * Add hook for retrieving PyOTA library version * Clean up IOTA library imports * Ensure seed is not displayed in cleartext * Fix invalid depth * Misc PEP8 formatting fixes Signed-off-by: Tyler Baker <tyler.baker@iota.org>
|
Hey @redondo-mk thanks so much for working on this! I will take a look this weekend 😺 |
…example examples: cleanups for better user experience
…alue Setting default value for depth to 3
|
Looks great, thanks @redondo-mk !! There's a few remaining references hiding out in the |
|
Sorry that I missed that - tests didn't save me there. I belive it should be good now. |
|
jeje no worries. Thanks @redondo-mk !! Gonna give this a final once-over, and then it should be ready to merge. |
marko-k0
force-pushed
the
185_symbols_in_transaction_init
branch
from
0154c53 to
4a1181e
Compare
|
I've tried to update my email address from my first commit in this branch and I've done something wrong. I've created another branch 185_symbols_in_transaction_init2 which has changes relevant to #185. I apologize for inconvenience! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #185 . Please review and let me know if I missed something.