Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iota-data-ingestion-core]: Use CancellationToken #4383

Open
sergiupopescu199 opened this issue Dec 6, 2024 · 0 comments · May be fixed by #4638
Open

[iota-data-ingestion-core]: Use CancellationToken #4383

sergiupopescu199 opened this issue Dec 6, 2024 · 0 comments · May be fixed by #4638
Assignees
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.

Comments

@sergiupopescu199
Copy link
Contributor

Description

Currently the IndexerExecutor run method accepts as an argument an oneshot::Receiver<()> to handle graceful shutdown, this is fine but the issue is that some crates use CancellationToken and other use a oneshot channel, to make things compatible it would be better to use the CancellationToken as it can be cloned easily and all tasks which listens to the same CancellationToken can be gracefully shutdown easily.

@sergiupopescu199 sergiupopescu199 added infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. labels Dec 6, 2024
@sergiupopescu199 sergiupopescu199 self-assigned this Dec 6, 2024
@sergiupopescu199 sergiupopescu199 changed the title [iota-data-ingestion-core]: Use CancellationToken [iota-data-ingestion-core]: Use CancellationToken Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant