Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use CancellationToken for IndexerExecutor #4638

Merged
merged 4 commits into from
Jan 15, 2025
Merged

refactor: use CancellationToken for IndexerExecutor #4638

merged 4 commits into from
Jan 15, 2025

Conversation

sergiupopescu199
Copy link
Contributor

@sergiupopescu199 sergiupopescu199 commented Dec 28, 2024 •
edited
Loading

Description of change

Use CancellationToken instead of an oneshot channel to gracefully shutdown the IndexerExecutor

Links to any relevant issues

fixes #4383

Type of change

  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

  • Code compiles
  • Existing tests pass

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code

@sergiupopescu199 sergiupopescu199 requested a review from a team as a code owner December 28, 2024 11:45
@iota-ci iota-ci added infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. labels Dec 28, 2024
@sergiupopescu199 sergiupopescu199 changed the title refactor: use CancellationToken for IndexerExecutor refactor: use CancellationToken for IndexerExecutor Dec 28, 2024
samuel-rufi
samuel-rufi approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@samuel-rufi samuel-rufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Great!

@sergiupopescu199 sergiupopescu199 requested a review from a team December 30, 2024 14:12
tomxey
tomxey approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@tomxey tomxey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌇

kodemartin
kodemartin approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎈

crates/iota-data-ingestion-core/src/executor.rs Outdated Show resolved Hide resolved
@vercel Vercel
Copy link

vercel bot commented Jan 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 0:33am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 0:33am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 0:33am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 0:33am

@sergiupopescu199 sergiupopescu199 requested a review from a team as a code owner January 15, 2025 12:32
@sergiupopescu199 sergiupopescu199 merged commit 343fc03 into develop Jan 15, 2025
47 checks passed
@sergiupopescu199 sergiupopescu199 deleted the sc-platform/issue-4383 branch January 15, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@kodemartin kodemartin kodemartin approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@tomxey tomxey tomxey approved these changes

Assignees
No one assigned
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iota-data-ingestion-core]: Use CancellationToken
6 participants
@sergiupopescu199 @tomxey @samuel-rufi @kodemartin @lucas-tortora @iota-ci