Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): remove deprecated lock details in AuthorityStore #3838

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Oct 31, 2024

Description of change

The LockDetails were moved to AuthorityPerEpochStore, but there was some deprecated logic that was necessary in case there were still entries in the old format. I assume we don't need that anymore. We only keep the table in the AuthorityStore to mark live objects.

Links to any relevant issues

#2092

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Let's see what the CI says? 😅

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@muXxer muXxer requested review from a team as code owners October 31, 2024 16:08
@muXxer muXxer added the node Issues related to the Core Node team label Oct 31, 2024
@thibault-martinez thibault-martinez mentioned this pull request Oct 31, 2024
18 tasks
@muXxer muXxer force-pushed the core-node/fix/remove-deprecated-lock-details branch from 67c2089 to d16780e Compare November 4, 2024 16:09
Copy link
Member

@alexsporn alexsporn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muXxer muXxer merged commit fd86e35 into develop Nov 4, 2024
39 of 41 checks passed
@muXxer muXxer deleted the core-node/fix/remove-deprecated-lock-details branch November 4, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants