-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node): remove deprecated lock details in AuthorityStore
#3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
bingyanglin
approved these changes
Nov 1, 2024
alexsporn
reviewed
Nov 4, 2024
alexsporn
reviewed
Nov 4, 2024
muXxer
force-pushed
the
core-node/fix/remove-deprecated-lock-details
branch
from
November 4, 2024 16:09
67c2089
to
d16780e
Compare
…ix/remove-deprecated-lock-details
alexsporn
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The
LockDetails
were moved toAuthorityPerEpochStore
, but there was some deprecated logic that was necessary in case there were still entries in the old format. I assume we don't need that anymore. We only keep the table in theAuthorityStore
to mark live objects.Links to any relevant issues
#2092
Type of change
How the change has been tested
Let's see what the CI says? 😅
Change checklist