Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ts-sdk): remove kiosks packages from env.defaults #3907

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

begonaalvarezd
Copy link
Member

Description of change

Close #3905

Links to any relevant issues

Be sure to reference any related issues by adding fixes #(issue).

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@begonaalvarezd begonaalvarezd requested review from a team as code owners November 5, 2024 14:28
@begonaalvarezd begonaalvarezd self-assigned this Nov 5, 2024
@begonaalvarezd begonaalvarezd added tooling Issues related to the Tooling team ts-sdk Issues related to the TS SDK labels Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 731d3fd

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-cywdc9zgj.vercel.app

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 731d3fd

✅ Preview: https://apps-ui-hr1r7xglx-iota1.vercel.app

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 731d3fd

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-j4gxokn31.vercel.app

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 731d3fd

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-ldfh0cazm.vercel.app

Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 666184c

✅ Preview: https://apps-ui-ihjkydp15-iota1.vercel.app

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 666184c

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-7q7srdjoe.vercel.app

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 666184c

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-ijgloqyhk.vercel.app

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 666184c

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-gyznmi1px.vercel.app

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 0221d2f

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-qwksybw6m.vercel.app

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 0221d2f

✅ Preview: https://apps-ui-ln7hcrcko-iota1.vercel.app

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 0221d2f

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-2oxvczov5.vercel.app

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 0221d2f

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-bp0dlrwpc.vercel.app

@begonaalvarezd begonaalvarezd requested a review from cpl121 November 5, 2024 15:16
@cpl121 cpl121 merged commit bce3651 into develop Nov 5, 2024
31 checks passed
@cpl121 cpl121 deleted the tooling-sdk/cleanup-envs branch November 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team ts-sdk Issues related to the TS SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup kiosks packages
3 participants