Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use tx_calls_fun instead of tx_calls relation #3999

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: Use tx_calls_fun instead of tx_calls relation #3999

merged 2 commits into from
Nov 11, 2024

Conversation

samuel-rufi
Copy link
Member

@samuel-rufi samuel-rufi commented Nov 11, 2024 •
edited
Loading

Description of change

Fixes the SQL query for the analytical worker by using tx_calls_fun instead of non existing tx_calls relation.

Links to any relevant issues

Fixes #3992

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@samuel-rufi samuel-rufi requested a review from a team as a code owner November 11, 2024 13:05
@samuel-rufi samuel-rufi self-assigned this Nov 11, 2024
sergiupopescu199
sergiupopescu199 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@sergiupopescu199 sergiupopescu199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🦀

@samuel-rufi samuel-rufi added the infrastructure Issues related to the Infrastructure Team label Nov 11, 2024
@lzpap lzpap merged commit 5d06d15 into develop Nov 11, 2024
38 of 40 checks passed
@lzpap lzpap deleted the l1sc/infra/tx-calls-relation branch November 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiupopescu199 sergiupopescu199 sergiupopescu199 approved these changes

@lzpap lzpap lzpap approved these changes

@kodemartin kodemartin kodemartin approved these changes

@tomxey tomxey Awaiting requested review from tomxey

Assignees

@samuel-rufi samuel-rufi

Labels
infrastructure Issues related to the Infrastructure Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find relation tx_calls
4 participants
@samuel-rufi @kodemartin @lzpap @sergiupopescu199