feat(iota): update testnet and devnet urls #4001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thibault-martinez this only contains snapshot URLs, do we have them? |
lzpap
reviewed
Nov 11, 2024
crates/iota/src/client_commands.rs
Outdated
| @@ -1541,8 +1541,8 @@ impl IotaClientCommands { | |||
|
|
|||
| if let Ok(env) = active_env { | |||
| let network = match env.rpc().as_str() { | |||
| IOTA_DEVNET_URL => "https://faucet.devnet.iota.io/v1/gas", | |||
| IOTA_TESTNET_URL => "https://faucet.testnet.iota.io/v1/gas", | |||
| IOTA_DEVNET_URL => "https://faucet.devnet.iota.cafe/gas", | |||
There was a problem hiding this comment.
we should keep the v1/gas endpoints, as thet will be needed when we enable batched faucet, until then they automatically fall back to the serial faucet in the server
lzpap
reviewed
Nov 11, 2024
crates/iota/src/client_commands.rs
Outdated
| IOTA_DEVNET_URL => "https://faucet.devnet.iota.io/v1/gas", | ||
| IOTA_TESTNET_URL => "https://faucet.testnet.iota.io/v1/gas", | ||
| IOTA_DEVNET_URL => "https://faucet.devnet.iota.cafe/gas", | ||
| IOTA_TESTNET_URL => "https://faucet.testnet.iota.cafe/gas", |
lzpap
approved these changes
Nov 11, 2024
Alright, if we don't have these URLs then let's merge this PR and assess the other issue in another one. |
thibault-martinez
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the testnet and devnet urls as the previous ones where just placeholders
Fixes #4000