feat(docker): cleanup docker files #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muXxer
force-pushed
the
core-node/feat/cleanup-docker-files
branch
from
f6fe4ab to
80d9f19
Compare
muXxer
force-pushed
the
core-node/feat/cleanup-docker-files
branch
from
f1b7972 to
c31029f
Compare
|
The changed github workflow seems to parse and pass the rust toolchain version correctly. |
alexsporn
reviewed
Nov 14, 2024
muXxer
requested review from
msarcev,
thibault-martinez,
DaughterOfMars,
Dr-Electron and
a team
as code owners
bingyanglin
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
So I have ran the following DockerFile by using ./build.sh in each folder, which can generate images successfully.
- docker/iota-bridge-indexer/Dockerfile
- docker/iota-graphql-rpc/Dockerfile
- docker/iota-indexer-tidb/Dockerfile
- docker/iota-indexer/Dockerfile
- docker/iota-node/Dockerfile
- docker/iota-rosetta-local/Dockerfile
- docker/iota-source-validation-service/Dockerfile
- docker/iota-tools/Dockerfile
- docker/iota/Dockerfile
Closed
muXxer
force-pushed
the
core-node/feat/cleanup-docker-files
branch
from
a5030cc to
47d09fe
Compare
piotrm50
approved these changes
Nov 25, 2024
msarcev
approved these changes
Dec 4, 2024
Alex6323
pushed a commit
that referenced
this pull request
Dec 4, 2024
* feat(docker): use one common build script for most containers * feat(docker): cleanup and unify docker files (clang, target, flags) * remove(docker): remove unused `iota-services` docker files * rename(docker): rename `iota-source-service` to `iota-source-validation-service` * feat(workflow): add toolchain version to docker build workflow * chore(docker): move rosetta docker files to root docker folder * fix(docker): small cleanups and fixes --------- Co-authored-by: Bing-Yang <51323441+bingyanglin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3867
This PR does some cleanup of the existing dockerfiles in the repository.
The biggest change is that the correct toolchain version is read from the
rust-toolchain.toml, and then passed to the dockerfile to load the correct rust build image with the correct version.It also introduces the usage of
clangandlldto compile the binaries. This should speed up the whole image building process.The build scripts were all unified to one, which gets then called with the only parameter that actually was different between those scripts, which is the name of the resulting container.
All containers now accept the
PROFILEandCARGO_BUILD_FEATURESflags.The unused
iota-servicedockerfiles were removed. It was used for the nameservice which doesn't exist.The existing
iota-source-servicewas renamed toiota-source-validation-service, because that actually is what is build inside the container.The rosetta docker files were moved to the root docker folder, instead of living inside of the iota-rosetta crate. This was the only exception in the repository, so I decided to move them to have a common place for all available dockerfiles.
Topics for discussion:
/usr/local/bininstead of/opt/iota/binfor the location of the binaries. Before there was a mix of both between the images. I personally prefer/usr/local/binbecause this is available system wide without modifications to the path variable, but I'm fine to change that in all containers if needed. (I now saw that they call the/usr/local/binthe legacy usage in one comment 👀 )iota-rosetta-devnetmakes any sense, because it clones another branch that doesn't even exist instead of using the local source. I would keep it for now, but we should cleanup rosetta in another PR, and it should be split into several containers (node, rosetta, cli) and use a docker compose file to unite them.