-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iota)!: show publicBase64Key without flag in keytool show
#4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iota-ci
added
dev-tools
Issues related to the Developer Tools Team
sc-platform
Issues related to the Smart Contract Platform group.
labels
Dec 27, 2024
alexsporn
approved these changes
Dec 28, 2024
DaughterOfMars
approved these changes
Dec 30, 2024
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Dec 31, 2024
Thoralf-M
changed the title
feat!(iota): show publicBase64Key without flag in
feat(iota)!: show publicBase64Key without flag in Dec 31, 2024
keytool show
keytool show
✅ Vercel Preview Deployment is ready! |
thibault-martinez
approved these changes
Dec 31, 2024
✅ Vercel Preview Deployment is ready! |
lucas-tortora
approved these changes
Jan 6, 2025
✅ Vercel Preview Deployment is ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev-tools
Issues related to the Developer Tools Team
documentation
Improvements or additions to documentation
sc-platform
Issues related to the Smart Contract Platform group.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
base64 encode public key without the type flag byte in the
keytool show
command so it's easier to compare against the data in the validator info (there it's also without the flag byte encoded).This change affects
CommandOutput::{Export, Generate, Import, List, Show}
Links to any relevant issues
Fixes #4311
Type of change
How the change has been tested
Added test and checked manually by running the command: