Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iota)!: show publicBase64Key without flag in keytool show #4637

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

Thoralf-M
Copy link
Member

@Thoralf-M Thoralf-M commented Dec 27, 2024

Description of change

base64 encode public key without the type flag byte in the keytool show command so it's easier to compare against the data in the validator info (there it's also without the flag byte encoded).

This change affects CommandOutput::{Export, Generate, Import, List, Show}

Links to any relevant issues

Fixes #4311

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Added test and checked manually by running the command:

iota keytool show 0x5f60f23c01486c6af8540144cf9fa74c167257b93c08fc33b74b8f173a885038.key
╭─────────────────┬──────────────────────────────────────────────────────────────────────╮
│ alias           │                                                                      │
│ iotaAddress     │  0x5f60f23c01486c6af8540144cf9fa74c167257b93c08fc33b74b8f173a885038  │
│ publicBase64Key │  svUb1I94/15y2k6LKaEWqNLFf1rNMHq0hcWFAJynu0g=                        │
│ keyScheme       │  ed25519                                                             │
│ flag            │  0                                                                   │
│ peerId          │  b2f51bd48f78ff5e72da4e8b29a116a8d2c57f5acd307ab485c585009ca7bb48    │
╰─────────────────┴──────────────────────────────────────────────────────────────────────╯

@Thoralf-M Thoralf-M requested a review from a team as a code owner December 27, 2024 16:33
@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Dec 27, 2024
@Thoralf-M Thoralf-M requested a review from a team as a code owner December 31, 2024 13:48
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 31, 2024
@Thoralf-M Thoralf-M changed the title feat!(iota): show publicBase64Key without flag in keytool show feat(iota)!: show publicBase64Key without flag in keytool show Dec 31, 2024
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Vercel Preview Deployment is ready!

View Preview

@thibault-martinez thibault-martinez merged commit 54e3342 into develop Jan 6, 2025
43 checks passed
@thibault-martinez thibault-martinez deleted the dev-tools/cli-show-cmd branch January 6, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tools Issues related to the Developer Tools Team documentation Improvements or additions to documentation sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove type byte from publicBase64Key in keytool show command
6 participants