feat(iota)!: unordered optional `IotaClientCommands::NewAddress` arguments #4647

thibault-martinez · 2024-12-31T10:44:13Z

Change the arguments of IotaClientCommands::NewAddress to be unordered and with flags. This is more consistent with the other client commands as this is the only one with ordered arguments. This is also a better UX as we currently have to provide all arguments if we only want to provide the last one. We can now provide only what is wanted.
Also made the key-scheme optional defaulting to Ed25519.

github-actions · 2024-12-31T11:12:19Z

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

github-actions · 2024-12-31T11:12:43Z

This pull request has been deployed to Vercel.

Latest commit: 148e666

✅ Preview: https://apps-backend-krtnicvp8-iota1.vercel.app

github-actions · 2024-12-31T11:13:26Z

This pull request has been deployed to Vercel.

Latest commit: 148e666

✅ Preview: https://wallet-dashboard-832fpi7t6-iota1.vercel.app

github-actions · 2024-12-31T11:13:35Z

This pull request has been deployed to Vercel.

Latest commit: 148e666

✅ Preview: https://rebased-explorer-b5mypwdsb-iota1.vercel.app

github-actions · 2024-12-31T11:15:58Z

✅ Vercel Preview Deployment is ready!

View Preview

crates/iota-sdk/README.md

docs/content/developer/dev-cheat-sheet.mdx

Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>

github-actions · 2024-12-31T12:23:08Z

This pull request has been deployed to Vercel.

Latest commit: 8e7cc10

✅ Preview: https://apps-backend-r2b5o5f4u-iota1.vercel.app

github-actions · 2024-12-31T12:23:40Z

This pull request has been deployed to Vercel.

Latest commit: 8e7cc10

✅ Preview: https://wallet-dashboard-fu4p39d9x-iota1.vercel.app

github-actions · 2024-12-31T12:23:49Z

This pull request has been deployed to Vercel.

Latest commit: 8e7cc10

✅ Preview: https://rebased-explorer-fz2h5qzmj-iota1.vercel.app

github-actions · 2024-12-31T12:26:11Z

✅ Vercel Preview Deployment is ready!

View Preview

crates/iota/src/client_commands.rs

vivekjain23

LGTM :)

github-actions · 2025-01-06T15:21:57Z

✅ Vercel Preview Deployment is ready!

View Preview

github-actions · 2025-01-06T15:25:19Z

This pull request has been deployed to Vercel.

Latest commit: ce9feae

✅ Preview: https://apps-backend-a1gq0lmo8-iota1.vercel.app

github-actions · 2025-01-06T15:25:30Z

This pull request has been deployed to Vercel.

Latest commit: ce9feae

✅ Preview: https://rebased-explorer-makt4qlpl-iota1.vercel.app

github-actions · 2025-01-06T15:25:58Z

This pull request has been deployed to Vercel.

Latest commit: ce9feae

✅ Preview: https://wallet-dashboard-71yhvljn6-iota1.vercel.app

github-actions · 2025-01-07T08:35:48Z

This pull request has been deployed to Vercel.

Latest commit: be3d954

✅ Preview: https://apps-backend-ox4um8zzw-iota1.vercel.app

github-actions · 2025-01-07T08:36:03Z

This pull request has been deployed to Vercel.

Latest commit: be3d954

✅ Preview: https://rebased-explorer-l59g9arr1-iota1.vercel.app

github-actions · 2025-01-07T08:36:27Z

This pull request has been deployed to Vercel.

Latest commit: be3d954

✅ Preview: https://wallet-dashboard-1kvmwdsoq-iota1.vercel.app

github-actions · 2025-01-07T08:38:33Z

✅ Vercel Preview Deployment is ready!

View Preview

github-actions · 2025-01-10T14:02:18Z

✅ Vercel Preview Deployment is ready!

View Preview

github-actions · 2025-01-10T14:03:01Z

This pull request has been deployed to Vercel.

Latest commit: df12c36

✅ Preview: https://rebased-explorer-ktmqn1g69-iota1.vercel.app

github-actions · 2025-01-10T14:03:50Z

This pull request has been deployed to Vercel.

Latest commit: df12c36

✅ Preview: https://apps-backend-47lkg48bs-iota1.vercel.app

github-actions · 2025-01-10T14:05:06Z

This pull request has been deployed to Vercel.

Latest commit: df12c36

✅ Preview: https://wallet-dashboard-1n62pr564-iota1.vercel.app

…ments (#4647) * cli: unordered optional `IotaClientCommands::NewAddress` arguments * optional key_scheme * docs * command doc * Update docs/content/developer/dev-cheat-sheet.mdx Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>

cli: unordered optional IotaClientCommands::NewAddress arguments

51b6820

iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Dec 31, 2024

thibault-martinez added 2 commits December 31, 2024 11:54

optional key_scheme

7f2592d

docs

b7ec73e

github-actions bot added documentation Improvements or additions to documentation ts-sdk Issues related to the TS SDK labels Dec 31, 2024

command doc

148e666

thibault-martinez marked this pull request as ready for review December 31, 2024 11:10

thibault-martinez requested review from a team as code owners December 31, 2024 11:10

Thoralf-M reviewed Dec 31, 2024

View reviewed changes

crates/iota-sdk/README.md Show resolved Hide resolved

Thoralf-M reviewed Dec 31, 2024

View reviewed changes

docs/content/developer/dev-cheat-sheet.mdx Outdated Show resolved Hide resolved

thibault-martinez changed the title ~~cli: unordered optional IotaClientCommands::NewAddress arguments~~ feat!(iota): unordered optional IotaClientCommands::NewAddress arguments Dec 31, 2024

Update docs/content/developer/dev-cheat-sheet.mdx

8e7cc10

Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>

thibault-martinez changed the title ~~feat!(iota): unordered optional IotaClientCommands::NewAddress arguments~~ feat(iota)!: unordered optional IotaClientCommands::NewAddress arguments Dec 31, 2024

DaughterOfMars reviewed Dec 31, 2024

View reviewed changes

crates/iota/src/client_commands.rs Show resolved Hide resolved

Thoralf-M approved these changes Dec 31, 2024

View reviewed changes

DaughterOfMars reviewed Dec 31, 2024

View reviewed changes

crates/iota/src/client_commands.rs Show resolved Hide resolved

vivekjain23 approved these changes Jan 2, 2025

View reviewed changes

Merge branch 'develop' into chore-cli-unordered-new-address-arguments

ce9feae

Merge branch 'develop' into chore-cli-unordered-new-address-arguments

be3d954

Alex6323 approved these changes Jan 7, 2025

View reviewed changes

begonaalvarezd approved these changes Jan 8, 2025

View reviewed changes

thibault-martinez marked this pull request as draft January 8, 2025 16:01

lucas-tortora approved these changes Jan 8, 2025

View reviewed changes

Merge branch 'develop' into chore-cli-unordered-new-address-arguments

2a29dc2

thibault-martinez marked this pull request as ready for review January 10, 2025 13:55

Merge branch 'develop' into chore-cli-unordered-new-address-arguments

df12c36

thibault-martinez merged commit 5026687 into develop Jan 10, 2025
43 checks passed

thibault-martinez deleted the chore-cli-unordered-new-address-arguments branch January 10, 2025 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(iota)!: unordered optional `IotaClientCommands::NewAddress` arguments #4647

feat(iota)!: unordered optional `IotaClientCommands::NewAddress` arguments #4647

thibault-martinez commented Dec 31, 2024 •

edited

Loading

github-actions bot commented Dec 31, 2024 •

edited

Loading

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

vivekjain23 left a comment

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

feat(iota)!: unordered optional IotaClientCommands::NewAddress arguments #4647

feat(iota)!: unordered optional IotaClientCommands::NewAddress arguments #4647

Conversation

thibault-martinez commented Dec 31, 2024 • edited Loading

github-actions bot commented Dec 31, 2024 • edited Loading

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

github-actions bot commented Dec 31, 2024

vivekjain23 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

feat(iota)!: unordered optional `IotaClientCommands::NewAddress` arguments #4647

feat(iota)!: unordered optional `IotaClientCommands::NewAddress` arguments #4647

thibault-martinez commented Dec 31, 2024 •

edited

Loading

github-actions bot commented Dec 31, 2024 •

edited

Loading