Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Regression: Update pruning test #1775

Merged
merged 4 commits into from
Apr 7, 2020

Conversation

DyrellC
Copy link
Contributor

@DyrellC DyrellC commented Mar 1, 2020

Description

Adds the requested before and after tests to confirm pruning occurred.

Fixes #1337

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Regression tests pass locally and with kubernetes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@DyrellC DyrellC changed the title Update pruning test for before and after pruning status Regression: Update pruning test Mar 1, 2020
@DyrellC
Copy link
Contributor Author

DyrellC commented Apr 6, 2020

@galrogo conflicts resolved

@GalRogozinski GalRogozinski merged commit 15fd278 into iotaledger:dev Apr 7, 2020
acha-bill pushed a commit to acha-bill/iri that referenced this pull request Apr 14, 2020
* Update pruning test for before and after pruning status

* m6 -> m1

Co-authored-by: Gal Rogozinski <gal.rogozinski@iota.org>
GalRogozinski added a commit that referenced this pull request Apr 21, 2020
* Move validation to validation service package

* Add Transaction Solidifier

* Update Transaction Validator

* Update Unit Tests

* Remove tip field from solidify stage

* Move broadcast queue retreival to solidify stage

* Undo auto-formatting

* More autoformatting

* Re-remove refillBroadcast

* Move propagation logic to inner class

* Remove unused imports

* Add comment to propagator

* Remove unused txSolidifier private field

* Remove separate thread logic, check solidity from milestone solidifier

* Add solidification queue to transaction solidifier

* LinkedHashSet -> ArrayDeque in checkSolidity

* Update maxProcessedTransactions value determination

* Make Transaction Propagator private

* Add milestone stage

* add heartbeat message (#1825)

* add heartbeat message

* added javadocs

* print exception message

* Regression: Update pruning test  (#1775)

* Update pruning test for before and after pruning status

* m6 -> m1

Co-authored-by: Gal Rogozinski <gal.rogozinski@iota.org>

* Fix: Update Broadcast Stage logic  (#1827)

* Update broadcast fetch logic

* Comment

* Feature: Add transaction solidifier queue (#1821)

* Move validation to validation service package

* Add Transaction Solidifier

* Update Transaction Validator

* Update Unit Tests

* Remove tip field from solidify stage

* Move broadcast queue retreival to solidify stage

* Undo auto-formatting

* More autoformatting

* Re-remove refillBroadcast

* Move propagation logic to inner class

* Remove unused imports

* Add comment to propagator

* Remove unused txSolidifier private field

* Remove separate thread logic, check solidity from milestone solidifier

* Add solidification queue to transaction solidifier

* LinkedHashSet -> ArrayDeque in checkSolidity

* Update maxProcessedTransactions value determination

* Make Transaction Propagator private

* Fix test conflicts

* Update src/main/java/com/iota/iri/service/validation/impl/TransactionSolidifierImpl.java

Co-Authored-By: Gal Rogozinski <galrogogit@gmail.com>

* Update src/main/java/com/iota/iri/service/validation/impl/TransactionSolidifierImpl.java

Co-Authored-By: Gal Rogozinski <galrogogit@gmail.com>

* Rename

Co-authored-by: Gal Rogozinski <gal.rogozinski@iota.org>
Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>

* Unit test for milestone stage

Co-authored-by: Gal Rogozinski <gal.rogozinski@iota.org>
Co-authored-by: Acha Bill <57879913+acha-bill@users.noreply.github.com>
Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>
GalRogozinski added a commit that referenced this pull request Apr 23, 2020
* Move validation to validation service package

* Add Transaction Solidifier

* Update Transaction Validator

* Update Unit Tests

* Remove tip field from solidify stage

* Move broadcast queue retreival to solidify stage

* Undo auto-formatting

* More autoformatting

* Re-remove refillBroadcast

* Move propagation logic to inner class

* Remove unused imports

* Add comment to propagator

* Remove unused txSolidifier private field

* Remove separate thread logic, check solidity from milestone solidifier

* Add solidification queue to transaction solidifier

* LinkedHashSet -> ArrayDeque in checkSolidity

* Update maxProcessedTransactions value determination

* Make Transaction Propagator private

* Add milestone stage

* add heartbeat message (#1825)

* add heartbeat message

* added javadocs

* print exception message

* Regression: Update pruning test  (#1775)

* Update pruning test for before and after pruning status

* m6 -> m1

Co-authored-by: Gal Rogozinski <gal.rogozinski@iota.org>

* Fix: Update Broadcast Stage logic  (#1827)

* Update broadcast fetch logic

* Comment

* Feature: Add transaction solidifier queue (#1821)

* Move validation to validation service package

* Add Transaction Solidifier

* Update Transaction Validator

* Update Unit Tests

* Remove tip field from solidify stage

* Move broadcast queue retreival to solidify stage

* Undo auto-formatting

* More autoformatting

* Re-remove refillBroadcast

* Move propagation logic to inner class

* Remove unused imports

* Add comment to propagator

* Remove unused txSolidifier private field

* Remove separate thread logic, check solidity from milestone solidifier

* Add solidification queue to transaction solidifier

* LinkedHashSet -> ArrayDeque in checkSolidity

* Update maxProcessedTransactions value determination

* Make Transaction Propagator private

* Fix test conflicts

* Update src/main/java/com/iota/iri/service/validation/impl/TransactionSolidifierImpl.java

Co-Authored-By: Gal Rogozinski <galrogogit@gmail.com>

* Update src/main/java/com/iota/iri/service/validation/impl/TransactionSolidifierImpl.java

Co-Authored-By: Gal Rogozinski <galrogogit@gmail.com>

* Rename

Co-authored-by: Gal Rogozinski <gal.rogozinski@iota.org>
Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>

* Unit test for milestone stage

* Consolidate milestone solidification logic

* Update milestone stage tests

* update bootstrap

* Minor refactor

* Log correct milestones, add switch for processing solidification queue

* Bootstrap milestone hash and index properly

* set index and hash directly instead of through method

* Place all milestone tails into solidifier from milestone stage

* setLatestMilestone -> logNewMilestone

* remove second LSM update in update milestones

* Stop repeats and solid entry points in broadcast queue

* Don't abort milestone stage for second transaction in milestone bundle

* Shorten regression wait times

* Clean up, syntax updates, comment clarification

* Remove unecessary method, syntax

* Atomic variables and syntax changes

* Update scanMilestones in queue

* Extract repair logic

* Update src/main/java/com/iota/iri/service/milestone/MilestoneSolidifier.java

Co-Authored-By: Gal Rogozinski <galrogogit@gmail.com>

* Typo, check solidity in milestone stage

* syntax and minor logic change

* Rename logNewMilestone

* log -> register in milestone stage

* Update milestone payload to pass forward transaction, fix tests

Co-authored-by: Gal Rogozinski <gal.rogozinski@iota.org>
Co-authored-by: Acha Bill <57879913+acha-bill@users.noreply.github.com>
Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>
@GalRogozinski GalRogozinski mentioned this pull request May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression test: DB Pruning works correctly on a pruning enabled node
2 participants