Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added listen to wasm #1879

Merged
merged 25 commits into from
Mar 20, 2023
Merged

Added listen to wasm #1879

merged 25 commits into from
Mar 20, 2023

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Feb 20, 2023 •
edited by Thoralf-M
Loading

Description of change

Added event listening to wasm

TODO:

  • Add example without using testnet

Links to any relevant issues

fixes #1872

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Listened for events on web and node

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

kwek20
kwek20 commented Feb 20, 2023
View reviewed changes
Thoralf-M
Thoralf-M previously approved these changes Mar 11, 2023
View reviewed changes
@thibault-martinez thibault-martinez mentioned this pull request Mar 27, 2023
Closed
thibault-martinez
thibault-martinez requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@Thoralf-M Thoralf-M merged commit 58713de into iotaledger:develop Mar 20, 2023
@github-actions github-actions bot mentioned this pull request Mar 20, 2023
Closed
This was referenced Apr 4, 2023
Open
Open
Open
@github-actions github-actions bot mentioned this pull request May 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement listen on wasm bindings
3 participants
@kwek20 @thibault-martinez @Thoralf-M