Skip to content

Commit

Permalink
Fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
vitaliyb committed Jan 15, 2025
1 parent d46aa72 commit ceccca7
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 18 deletions.
13 changes: 8 additions & 5 deletions packages/evm/jsonrpc/jsonrpctest/jsonrpc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -628,20 +628,23 @@ func TestRPCTraceEVMDeposit(t *testing.T) {
require.EqualValues(t, types.ReceiptStatusSuccessful, rc.Status)

t.Run("callTracer_tx", func(t *testing.T) {
trace, err := env.traceTransactionWithCallTracer(tx.Hash())
var trace jsonrpc.CallFrame
trace, err = env.traceTransactionWithCallTracer(tx.Hash())
require.NoError(t, err)
require.Equal(t, evmAddr.String(), trace.To.String())
require.Equal(t, hexutil.EncodeUint64(isc.NewAssetsBaseTokens(1000).BaseTokens*1e12), trace.Value.String())
})

t.Run("prestateTracer_tx", func(t *testing.T) {
prestate, err := env.traceTransactionWithPrestate(tx.Hash())
var prestate jsonrpc.PrestateAccountMap
prestate, err = env.traceTransactionWithPrestate(tx.Hash())
require.NoError(t, err)
require.Empty(t, prestate)
})

t.Run("prestateTracerDiff_tx", func(t *testing.T) {
prestateDiff, err := env.traceTransactionWithPrestateDiff(tx.Hash())
var prestateDiff jsonrpc.PrestateDiffResult
prestateDiff, err = env.traceTransactionWithPrestateDiff(tx.Hash())
require.NoError(t, err)
require.Empty(t, prestateDiff.Pre)
require.Empty(t, prestateDiff.Post)
Expand All @@ -660,7 +663,7 @@ func TestRPCTraceEVMDeposit(t *testing.T) {
)
require.NoError(t, err)

var traces = make([]jsonrpc.TxTraceResult, 0)
traces := make([]jsonrpc.TxTraceResult, 0)
err = json.Unmarshal(res1, &traces)
require.NoError(t, err)
require.Len(t, traces, 1)
Expand All @@ -686,7 +689,7 @@ func TestRPCTraceEVMDeposit(t *testing.T) {
)
require.NoError(t, err)

var traces = make([]jsonrpc.TxTraceResult, 0)
traces := make([]jsonrpc.TxTraceResult, 0)
err = json.Unmarshal(res1, &traces)
require.NoError(t, err)
require.Len(t, traces, 1)
Expand Down
19 changes: 9 additions & 10 deletions packages/evm/jsonrpc/tracer_call.go
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ var ErrIncorrectTopLevelCalls = errors.New("incorrect number of top-level calls"
// error arising from the encoding or forceful termination (via `Stop`).
func (t *callTracer) GetResult() (json.RawMessage, error) {
if t.traceBlock {

// otherwise return all call frames
results := make([]TxTraceResult, 0, len(t.txToStack))
for txHash, stack := range t.txToStack {
Expand All @@ -318,18 +317,18 @@ func (t *callTracer) GetResult() (json.RawMessage, error) {
return nil, err
}
return res, t.reason
} else {
if len(t.txToStack) != 1 {
return nil, ErrIncorrectTopLevelCalls
}
}

res, err := json.Marshal(t.txToStack[t.currentTx][0])
if err != nil {
return nil, err
}
if len(t.txToStack) != 1 {
return nil, ErrIncorrectTopLevelCalls
}

return res, t.reason
res, err := json.Marshal(t.txToStack[t.currentTx][0])
if err != nil {
return nil, err
}

return res, t.reason
}

// Stop terminates execution of the tracer at the first opportune moment.
Expand Down
9 changes: 6 additions & 3 deletions packages/evm/jsonrpc/tracer_prestate.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,8 @@ func (t *prestateTracer) GetResult() (json.RawMessage, error) {
if t.config.DiffMode {
result := []TxTraceResult{}
for txHash, txState := range t.states {
diffResult, err := json.Marshal(PrestateDiffResult{txState.Post, txState.Pre})
var diffResult json.RawMessage
diffResult, err = json.Marshal(PrestateDiffResult{txState.Post, txState.Pre})
if err != nil {
return nil, err
}
Expand All @@ -221,15 +222,17 @@ func (t *prestateTracer) GetResult() (json.RawMessage, error) {
} else {
result := []TxTraceResult{}
for txHash, txState := range t.states {
preState, err := json.Marshal(txState.Pre)
var preState json.RawMessage
preState, err = json.Marshal(txState.Pre)
if err != nil {
return nil, err
}
result = append(result, TxTraceResult{TxHash: txHash, Result: preState})
}

for _, tx := range t.fakeTxs {
csJSON, err := t.TraceFakeTx(tx)
var csJSON json.RawMessage
csJSON, err = t.TraceFakeTx(tx)
if err != nil {
return nil, err
}
Expand Down

0 comments on commit ceccca7

Please sign in to comment.