[api] impl eth_feeHistory #4527
Merged
+280
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
dustinxie
reviewed
Dec 24, 2024
| for i, p := range percentiles { | ||
| idx := int(float64(len(ascFees)) * p) | ||
| if idx >= len(ascFees) { | ||
| idx = len(ascFees) - 1 |
There was a problem hiding this comment.
is it possible this if can enter multiple times in the loop?
There was a problem hiding this comment.
It should only happens when p equlas 1, b/c the convertion from float to int will truncate the decimal part in Golang
dustinxie
reviewed
Dec 24, 2024
gasstation/cache.go
Outdated
|
|
||
| type blockPercents struct { | ||
| ascEffectivePriorityFees []*big.Int | ||
| } |
There was a problem hiding this comment.
i think can directly add into gasstation.go? seems too less of code change to make a new file
dustinxie
approved these changes
Dec 24, 2024
CoderZhi
approved these changes
Dec 24, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
impl the eth_feeHistory API
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: