Run missing browser tests on Travis #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
approved these changes
Jul 24, 2018
|
|
||
| yarn test-chrome | ||
| fold_start "test-chrome" |
There was a problem hiding this comment.
yes, this part is cleaner
| @@ -19,6 +19,12 @@ const pendingWithoutTendermint = () => { | |||
| }; | |||
|
|
|||
| describe("Web4Write", () => { | |||
| it("can be constructed with no chains", () => { | |||
There was a problem hiding this comment.
good empty case, so we can support adding later
|
Looks good, please resolve conflict and merge |
added 2 commits
July 25, 2018 07:41
we need at least 1 running spec for karma to succeed
webmaster128
force-pushed
the
travis-browsertests
branch
from
3dcf0fc to
1db5db2
Compare
Run test-chrome, test-safari, test-firefox in all packages where the commands exist
webmaster128
force-pushed
the
travis-browsertests
branch
from
1db5db2 to
94fc1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #189
Browser tests for iov-encoding and iov-api have not been executed.
I now changed the script such that test-chrome, test-safari, test-firefox are executed in all packages where they exist.