Limit upper voting power

iov-one · Jan 25, 2019 · 8928c71 · 8928c71
1 parent 72a43e7
commit 8928c71
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/x/validators/msg.go b/x/validators/msg.go
@@ -1,6 +1,7 @@
 package validators
 
 import (
+	"math"
 	"strings"
 
 	"github.com/iov-one/weave"
@@ -23,7 +24,7 @@ func (m ValidatorUpdate) Validate() error {
 		strings.ToLower(m.Pubkey.Type) != "ed25519" {
 		return errors.WithCode(errInvalidPubKey, CodeInvalidPubKey)
 	}
-	if m.Power < 0 {
+	if m.Power < 0 || m.Power > math.MaxInt64/8 {
 		return errors.WithCode(errInvalidPower, CodeInvalidPower)
 	}
 	return nil

diff --git a/x/validators/msg_test.go b/x/validators/msg_test.go
@@ -1,11 +1,11 @@
 package validators
 
 import (
+	"math"
 	"testing"
 
-	"github.com/tendermint/tendermint/crypto/ed25519"
-
 	"github.com/stretchr/testify/assert"
+	"github.com/tendermint/tendermint/crypto/ed25519"
 )
 
 func TestValidate(t *testing.T) {
@@ -39,6 +39,12 @@ func TestValidate(t *testing.T) {
 			}},
 			expError: true,
 		},
+		"Power must not exceed max": {
+			src: SetValidatorsMsg{[]*ValidatorUpdate{
+				{Pubkey: Pubkey{Data: keyEd25519[:], Type: "ed25519"}, Power: math.MaxInt64/8 + 1},
+			}},
+			expError: true,
+		},
 	}
 	for msg, spec := range specs {
 		t.Run(msg, func(t *testing.T) {