Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ticker for min fee - no wildcard #369

Closed
alpe opened this issue Mar 4, 2019 · 2 comments · Fixed by #385
Closed

Require ticker for min fee - no wildcard #369

alpe opened this issue Mar 4, 2019 · 2 comments · Fixed by #385
Assignees

Comments

@alpe
Copy link
Contributor

alpe commented Mar 4, 2019

Is your feature request related to a problem? Please describe.
I can see the additional complexity that comes with it in the code and also the the uncertainty for a an end user in terms of actual tx costs.

Describe the solution you'd like
Fail fast in init phase when fee is set without a ticker.

Describe alternatives you've considered
As I don't know the history why we have the wildcard I must assume we may want to support a list of options like gaiad: Minimum gas prices to accept for transactions; Any fee in a tx must meet this minimum (e.g. 0.01photino;0.0001stake). the ; is the OR but a , would be AND.

@ethanfrey
Copy link
Contributor

This is a very good cleanup related to #364

We can consider multiple fee tokens at a later date, but for the foreseeable future, the only known production user of weave is iov, and they will only allow iov tokens for fees. When there is a clear usecase and need, we can revisit the multiple fee-token alternative described above.

@ethanfrey
Copy link
Contributor

This still needs to be done for the (static) FeeDecorator. DynamicFeeDecorator was already fixed

@husio husio self-assigned this Mar 7, 2019
husio added a commit that referenced this issue Mar 7, 2019
@husio husio closed this as completed in #385 Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants