Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove composite literal uses of unkeyed fields #403

Closed
2 tasks done
husio opened this issue Mar 14, 2019 · 0 comments · Fixed by #430
Closed
2 tasks done

Remove composite literal uses of unkeyed fields #403

husio opened this issue Mar 14, 2019 · 0 comments · Fixed by #430
Assignees

Comments

@husio
Copy link
Contributor

husio commented Mar 14, 2019

This is a fresh take on go vet discussion. Previous story is #229 (comment)

We require go vet to pass as part of our test suite. We run it with -composites=false. This is a compromise because we used to have a huge amount of unkeyed fields, mostly in test files.

I have checked it again and today there is very little left.

$ go vet github.com/iov-one/weave/... 2>&1 | wc -l
42
$ go vet github.com/iov-one/weave/... 2>&1 | grep -v examples | wc -l
11

Acceptance criteria

  • replace all unkeyed fields with recommended assignment
  • remove -composites=false flag from go vet in Makefile
@husio husio added the cleanup label Mar 14, 2019
@husio husio self-assigned this Mar 21, 2019
husio added a commit that referenced this issue Mar 21, 2019
Replace all unkeyed fields with recommended assignment.

fix #403
husio added a commit that referenced this issue Mar 21, 2019
Replace all unkeyed fields with recommended assignment.

fix #403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants