Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor payment channel timeout #481

Closed
husio opened this issue Apr 3, 2019 · 0 comments
Closed

Refactor payment channel timeout #481

husio opened this issue Apr 3, 2019 · 0 comments
Assignees
@husio

Comments

@husio
Copy link
Contributor

husio commented Apr 3, 2019

The current x/paychan extension implementation relies on timeout based on block height. It would be an improvement to change the timeout to use a wall clock, similar to how it is done in the x/escrow extension.

Use seconds precision similar to what is proposed in #447
@husio husio added the 🐇 🥚 label Apr 3, 2019
@ethanfrey ethanfrey mentioned this issue Apr 5, 2019
Closed
31 tasks
@husio husio assigned husio and unassigned husio Apr 17, 2019
@husio husio self-assigned this May 8, 2019
husio added a commit that referenced this issue May 9, 2019
@husio
x/paychan: use wall clock for the timeout
c225778 
Use the wall clock value to determine a Payment Channel timeout in the
`x/paychan` extension. This is a change similar to the one done in
`x/escrow`.

`escrow.isExpired` was copied to the root level `weave` package as
`IsExpired`. Next change is to update `x/escrow` to use it instead of
the local implementation.

resolve #481
husio added a commit that referenced this issue May 9, 2019
@husio
x/paychan: use wall clock for the timeout
3ddbad6 
Use the wall clock value to determine a Payment Channel timeout in the
`x/paychan` extension. This is a change similar to the one done in
`x/escrow`.

`escrow.isExpired` was copied to the root level `weave` package as
`IsExpired`. Next change is to update `x/escrow` to use it instead of
the local implementation.

resolve #481
@husio husio closed this as completed in 2502225 May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@husio husio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@husio