Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors package improvements #494

Closed
2 tasks
ruseinov opened this issue Apr 4, 2019 · 0 comments · Fixed by #598
Closed
2 tasks

errors package improvements #494

ruseinov opened this issue Apr 4, 2019 · 0 comments · Fixed by #598
Assignees
@husio

Comments

@ruseinov
Copy link
Contributor

ruseinov commented Apr 4, 2019 •
edited
Loading

  • Make successABCICode public to reuse it in weave package, as suggested in the corresponding ticket (for the non-error checks to be more descriptive)
  • Fix doc.go to reflect latest changes, as it's still referencing methods like New, that are no longer present
@ethanfrey ethanfrey mentioned this issue Apr 5, 2019
Closed
31 tasks
husio added a commit that referenced this issue May 8, 2019
@husio
errors: update documentation
7f14c07 
- make `successABCICode` public variable
- update documentation

resolve #494
@husio husio self-assigned this May 8, 2019
@husio husio closed this as completed in #598 May 8, 2019
@husio husio mentioned this issue May 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@husio husio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

errors: update documentation iov-one/weave
2 participants
@husio @ruseinov