do not rely only on transaction signatures #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `x/sigs` and `x/username` to not rely only on `x.AnySigner` but use it as a fallback. Always allow to enforece an address by setting it in the message and ignore signers order.
|
Interesting... Why use it as fallback, I mean what drove you to make user optional? |
This comment has been minimized.
This comment has been minimized.
|
It must be optional, because backward compatibility must be preserved. We cannot change functionality that was once executed on production. |
husio
added a commit
that referenced
this pull request
Dec 16, 2019
This change is a reverse of modification introduced in 0.23.0 release. Do not allow to explicitely specify a new token owner. Rely on the `AnySigner` result. The above was an improvement. We deprecate `x/username` pacakge and do not want to introduce more work, even if those are fixing issues. resolve #1066
husio
added a commit
that referenced
this pull request
Dec 16, 2019
This change is a reverse of modification introduced in 0.23.0 release. Do not allow to explicitely specify a new token owner. Rely on the `AnySigner` result. The above was an improvement. We deprecate `x/username` pacakge and do not want to introduce more work, even if those are fixing issues. resolve #1066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
x/sigsandx/usernameto not rely only onx.AnySignerbutuse it as a fallback. Always allow to enforce an address by setting it
in the message and ignore signers order.
This is a backward compatible change, because new fields are optional.