Add protobuf linter #314
Add protobuf linter #314
Conversation
|
|
||
| prototool-bin: | ||
| ifndef $(shell command -v prototool help > /dev/null) | ||
| @@curl -sSL https://github.com/uber/prototool/releases/download/v1.3.0/prototool-$(shell uname -s)-$(shell uname -m) -o $(HOME)/.bin/prototool |
There was a problem hiding this comment.
Is there a better place than $HOME/.bin to store it? I wonder how this should work on CI.
There was a problem hiding this comment.
It is a Go project, you could also store it via go install in the GOPATH
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
======================================
Coverage 71.5% 71.5%
======================================
Files 146 146
Lines 6335 6335
======================================
Hits 4530 4530
Misses 1365 1365
Partials 440 440Continue to review full report at Codecov.
|
|
|
||
| prototool-bin: | ||
| ifndef $(shell command -v prototool help > /dev/null) | ||
| @@curl -sSL https://github.com/uber/prototool/releases/download/v1.3.0/prototool-$(shell uname -s)-$(shell uname -m) -o $(HOME)/.bin/prototool |
There was a problem hiding this comment.
It is a Go project, you could also store it via go install in the GOPATH
|
I can add linter to makefile and CI when #312 is merged. Right now it's failing the build. I think once I will add it to CI, I might have to alter the configuration as well (ie. how the binary is installed). |
|
👍 good work. Very much appreciated! |
Add
make lintthat will run protobuf linter on our codebase.After finishing #262 all linter
errors should be gone and we can add
make lintto our CI.resolve #302