allow to chain nil value decorator #431

husio · 2019-03-21T16:11:13Z

For ease of configuration allow to pass a nil value decorator to the
decorator chain builder. Nil decorator must be ignored.

resolve #414

For ease of configuration allow to pass a nil value decorator to the decorator chain builder. Nil decorator must be ignored. resolve #414

ethanfrey

Very nice and clean.

Can you add one more test for cutoffNil to make it complete?

app/chain.go

app/chain_test.go

allow to chain nil value decorator

a8425f1

For ease of configuration allow to pass a nil value decorator to the decorator chain builder. Nil decorator must be ignored. resolve #414

husio requested a review from ethanfrey March 21, 2019 16:11

husio requested a review from alpe as a code owner March 21, 2019 16:11

This comment has been minimized.

Sign in to view

ethanfrey approved these changes Mar 21, 2019

View reviewed changes

app/chain.go Show resolved Hide resolved

app/chain_test.go Show resolved Hide resolved

add tests

7944533

husio merged commit 802e3d9 into master Mar 22, 2019

husio deleted the allow_chain_nil_decorator_issue_414 branch March 22, 2019 08:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow to chain nil value decorator #431

allow to chain nil value decorator #431

husio commented Mar 21, 2019

This comment has been minimized.

ethanfrey left a comment

allow to chain nil value decorator #431

allow to chain nil value decorator #431

Conversation

husio commented Mar 21, 2019

This comment has been minimized.

ethanfrey left a comment

Choose a reason for hiding this comment