Ethans gconf comments

[ethanfrey]

Code speaks a thousand docs.

I liked this approach. But made some changes. Please look at the diff.

1. removed magic. pass in the package name/key rather than auto-querying it
2. enforce validation on parsing
3. abstracted out some basic InitConfig logic to make it easy to integrate in each package
4. Ensure tests in gconf and x/cash pass
5. changed genesis format to

"conf": {
  "cash": {..},
...

Please review the code and let me know what you think. If you are good, we can clean up and use this approach

[husio]

I like this approach most of all as well. Requiring an explicit package name instead of using reflect is a good change.

This functionality is not complete yet and I would love to see it used in bnsd as well to get the feeling for how it will be used.

@alpe what do you think?

[husio]

This should land in #532 after merging. I think it's better to implement it before merging.

[ethanfrey]

Yeah, I was a bit sloppy on the details. If Alex likes the idea as well, we can flesh it out. I would also add validation rules and see how to update schema/config before merging to master.

But if we agree this is the direction we go, we can start working on the details. In office today or remote

[ethanfrey]

@husio This branch should be good to go.

I added the generic handler with some basic tests and also fixed all tests in cmd/* and examples/mycoin. Please run make test locally

If you like this, please merge it into your PR, rebase that PR on newest master, and then add any more changes you want to do to consider this finished. I am sure there is plenty left to improve, but the basic flow should work and captures all difficult logic in gconf.

[ethanfrey]

Oh, and this will need a nicely updated CHANGELOG before merging to master 😉