Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG cleanup #630

Merged
merged 8 commits into from
May 15, 2019
Merged

CHANGELOG cleanup #630

merged 8 commits into from
May 15, 2019

Conversation

husio
Copy link
Contributor

@husio husio commented May 14, 2019

I have manually edited and rewritten latest entries in the CHANGELOG
file. I have removed all points that were implementation specific (ie
tests) and are not important for the users.
I was trying to keep only information that is improtatnt for our users,
without going too much into implementation details.

ruseinov and others added 6 commits May 14, 2019 12:26
I have manually edited and rewritten latest entries in the CHANGELOG
file. I have removed all points that were implementation specific (ie
tests) and are not important for the users.
I was trying to keep only information that is improtatnt for our users,
without going too much into implementation details.
@husio husio requested review from ruseinov and webmaster128 May 14, 2019 14:25
Copy link
Contributor

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this version.

Except some things were erroneously moved from 0.15 to 0.14

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
- Simplify transaction message unpacking with `weave.LoadMsg`
- Initial version of the governance extension (`x/gov`)
- Signature verification in `x/sigs` extension costs gas now
- A new message `BumpSequenceMsg` for incrementing a user sequence value in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing:

  • Adjustments to escrow processing (timeout inclusive)
  • Added validator-subjective anti-spam fee

I do kind of like having a section "improvements" to mark some of the details there, like the overhaul of the testing framework. Even if it doesn't change the API it does document many days of work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that we want to show what we worked on because we are proud of the results. Is it really helpful for the readers though? Is it helpful for @webmaster128 (our only user that I know of 😆)

@husio
Copy link
Contributor Author

husio commented May 15, 2019

@ethanfrey I am a bit confused by the timing. I am using d6acfb0 as the version bump commit. Which one should I use instead? I should have used GitHub interface for this instead v0.14.0...master because we are tagging a random commit as the release 😢 3c1504e

@husio
Copy link
Contributor Author

husio commented May 15, 2019

Should be all good now. @ethanfrey please have a look once more.

I have created #631 because I believe this will be a recurring problem and it really sux to edit the CHANGELOG after the fact.

@ruseinov
Copy link
Contributor

This looks much better, thanks!

LGTM, I suppose Ethan needs to have another go at this as he seems informed about what goes where.

@ruseinov
Copy link
Contributor

@ethanfrey ^^ can you have a go at this so that we can merge and release? Thanks!

@ruseinov
Copy link
Contributor

@husio btw let's aim this at master directly and close the other PR that I've opened, I don't think it's necessary to merge one into another etc.

@husio husio changed the base branch from ruseinov-patch-1 to master May 15, 2019 11:53
@husio husio mentioned this pull request May 15, 2019
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice.
And I think the idea of adding checks to the CI is a great way for us to train ourselves to remember. Just like clicking that little project button on PRs....

@ethanfrey ethanfrey merged commit 01026c0 into master May 15, 2019
@ethanfrey ethanfrey deleted the ruseinov-patch-1-piotr branch May 15, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants