-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG cleanup #630
CHANGELOG cleanup #630
Conversation
I have manually edited and rewritten latest entries in the CHANGELOG file. I have removed all points that were implementation specific (ie tests) and are not important for the users. I was trying to keep only information that is improtatnt for our users, without going too much into implementation details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this version.
Except some things were erroneously moved from 0.15 to 0.14
- Simplify transaction message unpacking with `weave.LoadMsg` | ||
- Initial version of the governance extension (`x/gov`) | ||
- Signature verification in `x/sigs` extension costs gas now | ||
- A new message `BumpSequenceMsg` for incrementing a user sequence value in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also missing:
- Adjustments to escrow processing (timeout inclusive)
- Added validator-subjective anti-spam fee
I do kind of like having a section "improvements" to mark some of the details there, like the overhaul of the testing framework. Even if it doesn't change the API it does document many days of work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that we want to show what we worked on because we are proud of the results. Is it really helpful for the readers though? Is it helpful for @webmaster128 (our only user that I know of 😆)
@ethanfrey I am a bit confused by the timing. I am using d6acfb0 as the version bump commit. |
Changes between 0.13 and 14.0 v0.13.0...v0.14.0
Should be all good now. @ethanfrey please have a look once more. I have created #631 because I believe this will be a recurring problem and it really sux to edit the CHANGELOG after the fact. |
This looks much better, thanks! LGTM, I suppose Ethan needs to have another go at this as he seems informed about what goes where. |
@ethanfrey ^^ can you have a go at this so that we can merge and release? Thanks! |
@husio btw let's aim this at master directly and close the other PR that I've opened, I don't think it's necessary to merge one into another etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice.
And I think the idea of adding checks to the CI is a great way for us to train ourselves to remember. Just like clicking that little project button on PRs....
I have manually edited and rewritten latest entries in the CHANGELOG
file. I have removed all points that were implementation specific (ie
tests) and are not important for the users.
I was trying to keep only information that is improtatnt for our users,
without going too much into implementation details.