Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic actions for governance #633

Merged
merged 32 commits into from
May 20, 2019
Merged

Add generic actions for governance #633

Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
edae92a
Add generic interfaces for external logic: Executor / OptionLoader
ethanfrey May 15, 2019
6ac9a2a
Updated governance proposal types to use new spike design
ethanfrey May 15, 2019
5528767
Started big refactoring, addressing build errors for new message format
ethanfrey May 15, 2019
fc86251
Fix all build errors
ethanfrey May 16, 2019
d9023fc
Use loader and executor in handlers, and cleanup
ethanfrey May 16, 2019
8eca033
Updated protobuf for better electorate-election rule refs, fixed nami…
ethanfrey May 16, 2019
351b60d
Fixed up code to match new models
ethanfrey May 16, 2019
813b5c5
Add election rule context when executing successful vote
ethanfrey May 16, 2019
c71803b
Addressed most PR comments
ethanfrey May 17, 2019
89c1f7f
Remove use of weavetest
ethanfrey May 17, 2019
5bcd30e
Removed switch abuse, where it stood in for a series of if statements
ethanfrey May 17, 2019
84aebd9
Compile "test" protobuf for governance
ethanfrey May 17, 2019
9e34efd
Add TextResolutionMsg and TextResolutionHandler
ethanfrey May 17, 2019
311a828
Commented out all tests... working to compile one by one
ethanfrey May 17, 2019
b05979f
Enabled many tests
ethanfrey May 17, 2019
440dc26
Fixed init tests
ethanfrey May 17, 2019
5de1310
Enable all message tests
ethanfrey May 17, 2019
26f3621
Enable all model tests, only handler tests disabled
ethanfrey May 17, 2019
44c8872
Enabled first handler tests
ethanfrey May 18, 2019
b38bac8
Complete handler tests for multiple option types
ethanfrey May 18, 2019
be83f08
Enable DeleteProposal Handler tests
ethanfrey May 18, 2019
ee5f74a
Pulled out test helpers into separate file
ethanfrey May 19, 2019
4aad3ce
Clean up fixtures
ethanfrey May 19, 2019
915b81f
Enable Vote tests
ethanfrey May 19, 2019
d8d5628
Test UpdateElectorate and UpdateElectionRules
ethanfrey May 19, 2019
c0e82bf
Tally results tested for text proposals (noop)
ethanfrey May 19, 2019
9c49303
All tests enabled!
ethanfrey May 20, 2019
07af9a1
Tested and demoed using App* messages for one-step parsing
ethanfrey May 20, 2019
d258631
Fix linting errors
ethanfrey May 20, 2019
3559f4e
Address PR comments, part 1
ethanfrey May 20, 2019
352a92b
Finish godoc comments with periods
ethanfrey May 20, 2019
9356e7c
Last cleanup
ethanfrey May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,12 @@ protoc: protofmt protodocs
protoc --gogofaster_out=. $(PROTOC_FLAGS) x/escrow/*.proto
protoc --gogofaster_out=. $(PROTOC_FLAGS) x/paychan/*.proto
protoc --gogofaster_out=. $(PROTOC_FLAGS) x/currency/*.proto
protoc --gogofaster_out=. $(PROTOC_FLAGS) x/gov/*.proto
protoc --gogofaster_out=. $(PROTOC_FLAGS) x/aswap/*.proto
# a bit of playing around to rename output, so it is only available for testcode
rm -f x/gov/sample_test.go
protoc --gogofaster_out=. $(PROTOC_FLAGS) x/gov/*.proto
mv x/gov/sample_test.pb.go x/gov/sample_test.go
# now build all examples
for ex in $(EXAMPLES); do cd $$ex && make protoc && cd -; done

protodocs:
Expand Down
Loading