Fix some redundant spaces in the INSTALL.md #3977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some redundant spaces in the INSTALL.md some command line like : "curl -LO http://releases.llvm.org/7.0.1/llvm-7.0.1.src.tar.xz" should be "curl -LO http://releases.llvm.org/7.0.1/llvm-7.0.1.src.tar.xz".
JadeFlute0127
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
When "make install bcc" in CentOS system, we need the versions of llvm and clang to be greater than or equal to 10.0.0. Otherwise, an error will be reported as follows:
```
/tmp/bcc/src/cc/bpf_module.cc: In member function ‘virtual void ebpf::MyMemoryManager::notifyObjectLoaded(llvm::ExecutionEngine*, const llvm::object::ObjectFile&)’:
/tmp/bcc/src/cc/bpf_module.cc:108:46: error: no matching function for call to ‘llvm::object::SectionRef::getName() const’
auto sec_name = section.get()->getName();
```
^
Before #3808 is landed, I think this compilation error should be addressed. |
|
Since we intend to use more recent llvm compilers, changing to llvm10 from llvm7 looks good to me. |
1 similar comment
|
Since we intend to use more recent llvm compilers, changing to llvm10 from llvm7 looks good to me. |
|
Could you squash 4 commits into one with proper commit message? |
1 similar comment
|
Could you squash 4 commits into one with proper commit message? |
|
OK, I will close this PR and resubmit a new proper one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some redundant spaces in the INSTALL.md
some command line like : "curl -LO http://releases.llvm.org/7.0.1/llvm-7.0.1.src.tar.xz" should be "curl -LO http://releases.llvm.org/7.0.1/llvm-7.0.1.src.tar.xz".
And other:
When "make install bcc" in CentOS(7.X) system, we need the versions of llvm and clang to be greater than or equal to 10.0.0. Otherwise, an error will be reported as follows: