libbpf-tools: add funcinterval #5100
Conversation
Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
kknjh
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
| .parser = parse_arg, | ||
| .doc = argp_program_doc, | ||
| }; | ||
| struct funcinterval_bpf *obj; |
There was a problem hiding this comment.
Maybe you can add ensure_core_btf and cleanup_core_btf like
bcc/libbpf-tools/funclatency.c
Line 349 in 6acb86e
There was a problem hiding this comment.
I have modified and submitted it
There was a problem hiding this comment.
how about squashing this into the previous commit?
Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
|
|
||
| struct { | ||
| __uint(type, BPF_MAP_TYPE_HASH); | ||
| __uint(max_entries, 1); |
There was a problem hiding this comment.
If max_entries is always one, why is a hash map needed for hists? Wouldn't an array like in funclatency.bpf.c be sufficient?
If a single array is sufficient, several logics of this patch can be changed.
Please refer to funclatency.
| .parser = parse_arg, | ||
| .doc = argp_program_doc, | ||
| }; | ||
| struct funcinterval_bpf *obj; |
There was a problem hiding this comment.
how about squashing this into the previous commit?
| return 0; | ||
| } | ||
|
|
||
| static int split_pattern(const char *raw_pattern, enum TRACE_TYPE *type, |
There was a problem hiding this comment.
The function name should be descriptive enough to convey its purpose without needing to read the code.
| static int split_pattern(const char *raw_pattern, enum TRACE_TYPE *type, | ||
| const char **library, const char **pattern) | ||
| { | ||
| const char *string1, *string2, *string3; |
There was a problem hiding this comment.
variable name is not descriptive.
| lookup_key = next_key; | ||
| } | ||
|
|
||
| fd = bpf_map__fd(obj->maps.start); |
There was a problem hiding this comment.
Reusing a single variable for multiple purposes can confuse the reader.
Based on funcinterval.py from BCC by Edward Wu