ProcSyms: fix off-by-ones, use binary search to resolve addresses #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes, |
abirchall
pushed a commit
to abirchall/bcc
that referenced
this pull request
Jul 11, 2016
…visor#594) * libbcc: fix off-by-one errors in resolving adjacent modules/symbols, add test * libbcc: use binary search in ProcSyms::Module::find_addr()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
a) fixes a couple of off-by-one bugs in matching modules and symbols. Specifically, when given two adjacent symbols resolving the start address of the second symbol would incorrectly return the first symbol. This diff fixes the ProcSyms::Module code, removes the workaround in bcc_perf_map_foreach_sym(), and adds a test.
b) switches to a binary search in ProcSyms::Module::find_addr(). The current linear search isn't very good on large mappings (some of our JIT maps are hundreds of thousands of entries).