Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf maps: use idiomatic stop channel for PollStop #69

Closed
alban opened this issue Aug 9, 2017 · 0 comments
Closed

perf maps: use idiomatic stop channel for PollStop #69

alban opened this issue Aug 9, 2017 · 0 comments

Comments

@alban
Copy link
Collaborator

alban commented Aug 9, 2017

Capturing comment from weaveworks/tcptracer-bpf#49 (comment):

btw PollStop is rather non-idiomatic - the typical way to do this kind of signalling is to close() a channel of type struct{}.

Since the pollStop channel is not exposed, there is no API change and applications using gobpf would not require any update.

/cc @rade @schu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alban