Skip to content

Commit

Permalink
mm-madvise-split-out-mmap-locking-operations-for-madvise-fix-checkpat…
Browse files Browse the repository at this point in the history
…ch-fixes

WARNING: suspect code indent for conditional statements (8, 12)
torvalds#57: FILE: mm/madvise.c:1598:
+	if (is_memory_failure(behavior))
+	    return 0;

WARNING: Statements should start on a tabstop
#58: FILE: mm/madvise.c:1599:
+	    return 0;

WARNING: suspect code indent for conditional statements (8, 12)
torvalds#72: FILE: mm/madvise.c:1612:
+	if (is_memory_failure(behavior))
+	    return;

WARNING: Statements should start on a tabstop
torvalds#73: FILE: mm/madvise.c:1613:
+	    return;

Please run checkpatch prior to sending patches

Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 committed Feb 22, 2025
1 parent 1a53bc2 commit b6a4965
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions mm/madvise.c
Original file line number Diff line number Diff line change
Expand Up @@ -1596,7 +1596,7 @@ static bool is_memory_failure(int behavior)
static int madvise_lock(struct mm_struct *mm, int behavior)
{
if (is_memory_failure(behavior))
return 0;
return 0;

if (madvise_need_mmap_write(behavior)) {
if (mmap_write_lock_killable(mm))
Expand All @@ -1610,7 +1610,7 @@ static int madvise_lock(struct mm_struct *mm, int behavior)
static void madvise_unlock(struct mm_struct *mm, int behavior)
{
if (is_memory_failure(behavior))
return;
return;

if (madvise_need_mmap_write(behavior))
mmap_write_unlock(mm);
Expand Down

0 comments on commit b6a4965

Please sign in to comment.