update to industrial_ci

[souravran]

No description provided.

[mathias-luedtke]

yeah, another candidate for ros-industrial/industrial_ci#123
In this case we should fix cob_kinematics to use the build space.

[mathias-luedtke]

@souravran: you can run all tests in a docker-enabled shell with the run_ci script:

• clone industrial_ci into your workspace
• rosrun industrial_ci run_ci $PATH_TO_REPO ROS_DISTRO=indigo

[mathias-luedtke]

why did you add this?
I don't want to get mails for every failure.
The default works quite fine for me.

[souravran]

I am not aware of the intricacies for now, but if needed then we can roll back. @ipa-fmw

[fmessmer]

Well, if we remove this...I want it removed in all the other repositories, too
For the sake of consistency!

[mathias-luedtke]

For the sake of consistency!

Constistency does not matter in this case, it is just a preference of the maintainer.

However, I just found it that

  email:
    on_success: change
    on_failure: always

is the default (https://docs.travis-ci.com/user/notifications/).
So perhaps it would make sense to set on_failure: change.

[floweisshardt]

I strongly discourage you to set on_failure: change. If travis fails this should be a permanent thread to your mailbox until it is fixed properly :-)

[mathias-luedtke]

If travis fails this should be a permanent thread to your mailbox until it is fixed properly

Why? "on_failure: always" -> send mail on every error (default), "on_failure: change" -> send mail only for the first time and after it was resolved(?)

[mathias-luedtke]

My fix is working, but prevents the plugins from beeing used in devel space. So we might consider to remove cob_kinematics (#72)

[fmessmer]

So we might consider to remove cob_kinematics (#72)

I vote for removing cob_kinematics for the following reasons: #72 (comment)

[fmessmer]

replaced by #102