Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Options mode conflicts with preset mode #48

Merged
merged 2 commits into from
May 10, 2024

Conversation

ipetinate
Copy link
Owner

@ipetinate ipetinate commented May 10, 2024

Clingon CLI logo

Clingon Empire | Official Pull Request

Fill in the fields appropriately so that empire reviewers can validate your work.


Important

Do not publish using local npm, with each PR the Release CI pipeline is executed, ensuring version control, publication and creation of the release and changelog.

Warning

Don't forget to put the correct label before creating the PR, so that auto does not create canaries for code that it doesn't need (docs, internal, etc.) and versioning correctly for the code that needs to be published. To learn about labels, check the following documentation: Auto Release.


Description

  • Fix conflicts with required props from Options Mode and preset mode

Requirements

I did:

  • Unit tests
  • Code formatting
  • Documentation with JSDocs
  • (Optional) Documentation with Markdown
  • Documentation on github.com/ipetinate/clingon-dot-dev
  • Local Tests
  • I tested the canary release
  • I marked the Issue referring to the code (if you didn't create the branch from the issue)

Preview

Screen.Recording.2024-05-10.at.15.mp4

Canary Release

@ipetinate ipetinate added bug Something isn't working patch labels May 10, 2024
@ipetinate ipetinate self-assigned this May 10, 2024
@ipetinate ipetinate changed the title Fix/options mode conflicts fix: Options mode conflicts with preset mode May 10, 2024
@ipetinate ipetinate merged commit 9d5c1c3 into main May 10, 2024
2 checks passed
@ipetinate ipetinate deleted the fix/options-mode-conflicts branch May 10, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant