wants to rebuild pyo3

[brianmay]

This source: brianmay/robotica-rust@71d6bbb

Run nix build -L '.#brian-backend'.

First build in p9j1vwz1g2by1pv4w44gp1k0nryf59nh-robotica-rust-deps-0.1.0.drv:

++ command cargo check --release -p brian-backend --all-targets
[...]
   Compiling pyo3 v0.19.2

Second build in y28ggik47im066hqvzmdyxl96sxlbsfa-robotica-rust-0.1.0.drv:

++ command cargo build --release --message-format json-render-diagnostics -p brian-backend
error: failed to write `/build/9kcpq32j9mg20zb64h4nkb6a9qmav0v6-source/target/release/.fingerprint/pyo3-7b8477fb46871d44/lib-pyo3`

I don't understand why it doesn't like the existing build...

[brianmay]

In the latest version, de1501b368f74e60a211c4f1142124cf235733fd, I updated all inputs, and encountered the same problem.

[dpc]

Try use-zstd. Also buildPackage should probably inherit from buildDepsOnly, and inheriting from clippy is asking for trouble.

[brianmay]

What is use-zstd? Sorry, but have no idea here.

I think I copied using the clippy output from an example. I tried changing it before, it didn't seem to make any difference, will try again. Nope, didn't help.

[dpc]

https://github.com/ipetkov/crane/blob/master/docs/API.md installCargoArtifactsMode = "use-zstd";

[brianmay]

It seems that setting installCargoArtifactsMode = "use-zstd"; in my common flags helps. Thanks.

I still am unclear what this does or how it helps in this case though...

[ipetkov]

use-zstd results in all artifacts being copied into the builder directory, whereas (the default) use-symlink uses symlinks to the (readonly) Nix store. For some reason, cargo is wanting to touch a fingerprint file but failing unless the file is actually writable.

Not sure if this will shed any light but setting CARGO_LOG = "cargo::core::compiler::fingerprint=info" on the derivation might show why rebuilds are happening

[brianmay]

Something about the PATH changing? Have I interpreted this correctly?

[...]
2023-10-09T08:26:55.244132Z  INFO cargo::core::compiler::fingerprint: fingerprint dirty for pyo3 v0.19.2/Build/TargetInner { ..: lib_target("pyo3", ["lib"], "/nix/store/n5hksi2ahs749lhwj1sf1ir4jwhqym
5x-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/pyo3-0.19.2/src/lib.rs", Edition2018) }
2023-10-09T08:26:55.244141Z  INFO cargo::core::compiler::fingerprint:     dirty: UnitDependencyInfoChanged { old_name: "build_script_build", old_fingerprint: 17018453923488440359, new_name: "build_sc
ript_build", new_fingerprint: 3539448609405325510 }
2023-10-09T08:26:55.244318Z  INFO cargo::core::compiler::fingerprint: fingerprint dirty for pyo3 v0.19.2/RunCustomBuild/TargetInner { ..: custom_build_target("build-script-build", "/nix/store/n5hksi2
ahs749lhwj1sf1ir4jwhqym5x-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/pyo3-0.19.2/build.rs", Edition2018) }
2023-10-09T08:26:55.244326Z  INFO cargo::core::compiler::fingerprint:     dirty: UnitDependencyInfoChanged { old_name: "build_script_build", old_fingerprint: 12230799582734276092, new_name: "build_sc
ript_build", new_fingerprint: 4882433989848665905 }
2023-10-09T08:26:55.244363Z  INFO cargo::core::compiler::fingerprint: fingerprint dirty for pyo3 v0.19.2/Build/TargetInner { ..: custom_build_target("build-script-build", "/nix/store/n5hksi2ahs749lhw
j1sf1ir4jwhqym5x-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/pyo3-0.19.2/build.rs", Edition2018) }
2023-10-09T08:26:55.244369Z  INFO cargo::core::compiler::fingerprint:     dirty: UnitDependencyInfoChanged { old_name: "pyo3_build_config", old_fingerprint: 18200767868591385678, new_name: "pyo3_buil
d_config", new_fingerprint: 1568741510531718499 }
2023-10-09T08:26:55.244470Z  INFO cargo::core::compiler::fingerprint: fingerprint dirty for pyo3-build-config v0.19.2/Build/TargetInner { ..: lib_target("pyo3-build-config", ["lib"], "/nix/store/n5hk
si2ahs749lhwj1sf1ir4jwhqym5x-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/pyo3-build-config-0.19.2/src/lib.rs", Edition2018) }
2023-10-09T08:26:55.244477Z  INFO cargo::core::compiler::fingerprint:     dirty: UnitDependencyInfoChanged { old_name: "build_script_build", old_fingerprint: 6387761415568613567, new_name: "build_scr
ipt_build", new_fingerprint: 4852463659124669571 }
2023-10-09T08:26:55.244599Z  INFO cargo::core::compiler::fingerprint: fingerprint dirty for pyo3-build-config 
[log.txt](https://github.com/ipetkov/crane/files/12844009/log.txt)
v0.19.2/RunCustomBuild/TargetInner { ..: custom_build_target("build-script-build", "/nix/
store/n5hksi2ahs749lhwj1sf1ir4jwhqym5x-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/pyo3-build-config-0.19.2/build.rs", Edition2018) }
2023-10-09T08:26:55.244606Z  INFO cargo::core::compiler::fingerprint:     dirty: EnvVarChanged { name: "PATH", old_value: Some("/nix/store/lcf37pgp3rgww67v9x2990hbfwx96c1w-gcc-wrapper-12.2.0/bin:/nix/store/b7hvml0m3qmqraz1022fwvyyg6fc1vdy-gcc-12.2.0/bin:/nix/store/lyri4viji7lx2jwp5xy5fi1i1y0wx8z0-glibc-2.37-8-bin/bin:/nix/store/j4fwy5gi1rdlrlbk2c0vnbs7fmlm60a7-coreutils-9.1/bin:/nix/store/qnjzh4b0zgdkpb9x3r3h3bnc3rhdysbx-binutils-wrapper-2.40/bin:/nix/store/zkjq96ik8cbv6ijh1lylnkk2bni9qvas-binutils-2.40/bin:/nix/store/93fy4p3vrjpxkzrliql5lh51flcanx04-pkg-config-wrapper-0.29.2/bin:/nix/store/8jn766c8nzwhm3g42flmki9psrdya105-rust-default-1.73.0/bin:/nix/store/rc35ccxr2769yxygy8n44pga4i9vkqf2-rsync-3.2.7/bin:/nix/store/7gqmifamblx3zb25qcrxdsmsi3az7an2-zstd-1.5.5-bin/bin:/nix/store/jwvvq9nyfrjvj10pl533my6d3gpn9nq0-zstd-1.5.5/bin:/nix/store/5rbqiz11vagap5fsk3vw8fgznw6vxyrh-patchelf-0.15.0/bin:/nix/store/5x0cf6xglh7h6qszkflll6fspgl39jrb-openssl-3.0.10-bin/bin:/nix/store/bc45k1n0pkrdkr3xa6w84w1xhkl1kkyp-python3-3.10.12/bin:/nix/store/rkqghw7cc27qxf6iiqgg95rlzvf22s05-protobuf-3.21.12/bin:/nix/store/j4fwy5gi1rdlrlbk2c0vnbs7fmlm60a7-coreutils-9.1/bin:/nix/store/x6rwgp1jl5sgzwbsaigqkdbdc7krzwj7-findutils-4.9.0/bin:/nix/store/1x4qg9ap1x3b50z7j4mbdvqlf1sjkbf8-diffutils-3.9/bin:/nix/store/vqj2w8rqghmmp4wkn9lkcym5kzlqk372-gnused-4.9/bin:/nix/store/8mzvz6kk57p9aqdk72pq1adsl38bkzi6-gnugrep-3.7/bin:/nix/store/49q1zfhkan4k0rqyxfhj512nw2wwngsf-gawk-5.2.1/bin:/nix/store/mddiy1w0ikb2pd48c7fciw044csv536y-gnutar-1.35/bin:/nix/store/s9dzv58651xf1d6m5i48s17vkbipg5ww-gzip-1.12/bin:/nix/store/bsca0mm8zc66gnibdvp5wwpfqh5c91xa-bzip2-1.0.8-bin/bin:/nix/store/ik9ibmq0rbznwyj6472lv2ab0c397lhy-gnumake-4.4.1/bin:/nix/store/8fv91097mbh5049i9rglc73dx6kjg3qk-bash-5.2-p15/bin:/nix/store/0cw69kwj62xnid3bkcd3lylnwz7w6gn8-patch-2.7.6/bin:/nix/store/08bbg98v5l4aalxbr583mhpxasrwsf41-xz-5.4.3-bin/bin:/nix/store/2q1x5hazpr8yf5hh0pj09nmz94sc7q81-file-5.44/bin"), new_value: Some("/nix/store/lcf37pgp3rgww67v9x2990hbfwx96c1w-gcc-wrapper-12.2.0/bin:/nix/store/b7hvml0m3qmqraz1022fwvyyg6fc1vdy-gcc-12.2.0/bin:/nix/store/lyri4viji7lx2jwp5xy5fi1i1y0wx8z0-glibc-2.37-8-bin/bin:/nix/store/j4fwy5gi1rdlrlbk2c0vnbs7fmlm60a7-coreutils-9.1/bin:/nix/store/qnjzh4b0zgdkpb9x3r3h3bnc3rhdysbx-binutils-wrapper-2.40/bin:/nix/store/zkjq96ik8cbv6ijh1lylnkk2bni9qvas-binutils-2.40/bin:/nix/store/93fy4p3vrjpxkzrliql5lh51flcanx04-pkg-config-wrapper-0.29.2/bin:/nix/store/i1jf9af43mf4jpnz7angp62bfndm8ksd-jq-1.6-bin/bin:/nix/store/8jn766c8nzwhm3g42flmki9psrdya105-rust-default-1.73.0/bin:/nix/store/rc35ccxr2769yxygy8n44pga4i9vkqf2-rsync-3.2.7/bin:/nix/store/7gqmifamblx3zb25qcrxdsmsi3az7an2-zstd-1.5.5-bin/bin:/nix/store/jwvvq9nyfrjvj10pl533my6d3gpn9nq0-zstd-1.5.5/bin:/nix/store/5rbqiz11vagap5fsk3vw8fgznw6vxyrh-patchel
f-0.15.0/bin:/nix/store/5x0cf6xglh7h6qszkflll6fspgl39jrb-openssl-3.0.10-bin/bin:/nix/store/bc45k1n0pkrdkr3xa6w84w1xhkl1kkyp-python3-3.10.12/bin:/nix/store/rkqghw7cc27qxf6iiqgg95rlzvf22s05-protobuf-3.
21.12/bin:/nix/store/j4fwy5gi1rdlrlbk2c0vnbs7fmlm60a7-coreutils-9.1/bin:/nix/store/x6rwgp1jl5sgzwbsaigqkdbdc7krzwj7-findutils-4.9.0/bin:/nix/store/1x4qg9ap1x3b50z7j4mbdvqlf1sjkbf8-diffutils-3.9/bin:/
nix/store/vqj2w8rqghmmp4wkn9lkcym5kzlqk372-gnused-4.9/bin:/nix/store/8mzvz6kk57p9aqdk72pq1adsl38bkzi6-gnugrep-3.7/bin:/nix/store/49q1zfhkan4k0rqyxfhj512nw2wwngsf-gawk-5.2.1/bin:/nix/store/mddiy1w0ikb
2pd48c7fciw044csv536y-gnutar-1.35/bin:/nix/store/s9dzv58651xf1d6m5i48s17vkbipg5ww-gzip-1.12/bin:/nix/store/bsca0mm8zc66gnibdvp5wwpfqh5c91xa-bzip2-1.0.8-bin/bin:/nix/store/ik9ibmq0rbznwyj6472lv2ab0c39
7lhy-gnumake-4.4.1/bin:/nix/store/8fv91097mbh5049i9rglc73dx6kjg3qk-bash-5.2-p15/bin:/nix/store/0cw69kwj62xnid3bkcd3lylnwz7w6gn8-patch-2.7.6/bin:/nix/store/08bbg98v5l4aalxbr583mhpxasrwsf41-xz-5.4.3-bi
n/bin:/nix/store/2q1x5hazpr8yf5hh0pj09nmz94sc7q81-file-5.44/bin") }
2023-10-09T08:26:55.244783Z  INFO cargo::core::compiler::fingerprint: fingerprint dirty for pyo3-ffi v0.19.2/RunCustomBuild/TargetInner { ..: custom_build_target("build-script-build", "/nix/store/n5h
ksi2ahs749lhwj1sf1ir4jwhqym5x-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/pyo3-ffi-0.19.2/build.rs", Edition2018) }
2023-10-09T08:26:55.244790Z  INFO cargo::core::compiler::fingerprint:     dirty: UnitDependencyInfoChanged { old_name: "build_script_build", old_fingerprint: 11597840713969505893, new_name: "build_sc
ript_build", new_fingerprint: 2843237769727485489 }
2023-10-09T08:26:55.244827Z  INFO cargo::core::compiler::fingerprint: fingerprint dirty for pyo3-ffi v0.19.2/Build/TargetInner { ..: custom_build_target("build-script-build", "/nix/store/n5hksi2ahs74
9lhwj1sf1ir4jwhqym5x-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/pyo3-ffi-0.19.2/build.rs", Edition2018) }
2023-10-09T08:26:55.244833Z  INFO cargo::core::compiler::fingerprint:     dirty: UnitDependencyInfoChanged { old_name: "pyo3_build_config", old_fingerprint: 18200767868591385678, new_name: "pyo3_buil
d_config", new_fingerprint: 1568741510531718499 }
2023-10-09T08:26:55.244887Z  INFO cargo::core::compiler::fingerprint: fingerprint dirty for pyo3-ffi v0.19.2/Build/TargetInner { ..: lib_target("pyo3-ffi", ["lib"], "/nix/store/n5hksi2ahs749lhwj1sf1i
r4jwhqym5x-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/pyo3-ffi-0.19.2/src/lib.rs", Edition2018) }
2023-10-09T08:26:55.244894Z  INFO cargo::core::compiler::fingerprint:     dirty: UnitDependencyInfoChanged { old_name: "build_script_build", old_fingerprint: 4059428653758569626, new_name: "build_script_build", new_fingerprint: 16092455214680709487 }
[...]

I think only the new PATH has /nix/store/i1jf9af43mf4jpnz7angp62bfndm8ksd-jq-1.6-bin/bin, not sure if that is the only difference. Nor can I see anything that would be responsible for adding this to the path either. jq isn't something I use in this project.

Unfortunately the formatting of the above may have been messed up, here is the original log.txt.

[dpc]

In recent cargos -vvv prints quite a bit info about why it rebuilds stuff.

[ipetkov]

I wonder if the clippy execution is doing something (maybe re-running build scripts which are thrashing the cache?). If you change this line to inherit cargoArtifacts; (i.e. use the artifacts from buildDepsOnly and not cargoClippy) does that change anything?

[brianmay]

No, unfortunately that did not help.

[vlaci]

I managed to work this around by setting PYO3_PYTHON based on this comment PyO3/pyo3#1708 (comment)

commonArgs = {
  ...
  env.PYO3_PYTHON = "${python3}/bin/python";
};

Note, that if you want to set additional variables in concrete derivations, recursiveUpdate should be used instead of // when mixing in commonArgs:

craneLib.XXX (lib.recursiveUpdate commonArgs {
  ...
  env.RUST_LOG = "debug";
};

[ipetkov]

Thanks for the observation @vlaci, I've opened #486 to document it for anyone else who runs into this!