-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service-config and expose metrics #97
base: main
Are you sure you want to change the base?
Conversation
Let's get the ginkgo versioning fix in #94 merged into main and then we can rebase this branch and retry the build. |
) | ||
|
||
func GetDefaultServiceConfig() *cmdutils.ConfigHelper { | ||
cfgHelper := cmdutils.NewConfigHelper("", "", "crdt", "badger") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use flatfs for the datastore so that should also be set here. Maybe this can be parameterized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coryschwartz Does IPFS Cluster maintain its own blockstore or does this value need to be in sync with what we use for the IPFS nodes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have copied this from ipfs-cluster project. Default value is badger.
From the code - here I can see flatfs is not a valid value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsanjuan We would need to use flatfs
here as well correct? ipfs-cluster/cmdutils
doesn't seem to support flatfs as a valid value for the datastore, will we need to add support for it?
Suggested edit: diff --git a/controllers/ipfs_cluster_service.go b/controllers/ipfs_cluster_service.go
index cb10c4c..7a2ab9c 100644
--- a/controllers/ipfs_cluster_service.go
+++ b/controllers/ipfs_cluster_service.go
@@ -6,7 +6,7 @@ import (
)
func GetDefaultServiceConfig() *cmdutils.ConfigHelper {
- cfgHelper := cmdutils.NewConfigHelper("", "", "crdt", "badger")
+ cfgHelper := cmdutils.NewConfigHelper("", "", "crdt", "flatfs")
err := cfgHelper.Manager().Default()
if err != nil {
return nil
|
@patilsuraj767 Now that we merged #94, you can rebase this one and it should clear up the build issue as well. |
e92e610
to
62a8898
Compare
@patilsuraj767 For some reason it's still running the old workflow in CI, you'll have to rebase to get the tests to pass. |
5b33e6f
to
03ae15d
Compare
@patilsuraj767 This PR looks like it's in working order according to the CI which is good. I only have a few other things that I can think of:
Once those two things, I think we should be ready to merge. |
fixes: #95
fixes: #96
Below are the changes made in this PR