Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt(vsmgr): cleanup message id if snap up meet error can retry #545

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

remakeZK
Copy link
Contributor

@remakeZK remakeZK commented Dec 14, 2022

关联的Issues (Related Issues)

改动 (Proposed Changes)

修改snapup对于消息处理和可重试错误的逻辑,在遇到outofgas或者钱不足等问题时自己进行重试

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合 Venus 项目管理规范中关于 PR 的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的 commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@remakeZK remakeZK added the vsmgr vsmgr related issue label Dec 14, 2022
@remakeZK remakeZK self-assigned this Dec 14, 2022
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit a306adb into main Dec 14, 2022
@diwufeiwen diwufeiwen deleted the remakeZK/opt/snap_up_optimize branch December 14, 2022 07:08
@0x5459 0x5459 added needs-cherry-pick-0.4 Need cherry pick to release 0.4 needs-cherry-pick-0.5 Need cherry pick to release 0.5 labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-0.4 Need cherry pick to release 0.4 needs-cherry-pick-0.5 Need cherry pick to release 0.5 vsmgr vsmgr related issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants